Add parse_macro_arguments to unify how we handle macro inputs #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
force-pushed
the
od/parse-macro-arguments
branch
from
e2e5135 to
e98d59c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3616 +/- ##
==========================================
- Coverage 98.31% 98.21% -0.11%
==========================================
Files 43 43
Lines 5645 5663 +18
==========================================
+ Hits 5550 5562 +12
- Misses 95 101 +6 ☔ View full report in Codecov by Sentry. |
odow
force-pushed
the
od/parse-macro-arguments
branch
from
0ae13b3 to
3b8fe8b
Compare
odow
commented
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3513
The main benefit of this is that it provides a public API via
Containers.parse_macro_arguments, and it deals with theparameterstuff that happens when you have;keywords in a macro.