Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcasting f-in-set in constraint macro #3632

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Dec 17, 2023

x-ref #3629

So this line was never covered:
https://app.codecov.io/gh/jump-dev/JuMP.jl/commit/419c3344c9a62692e344da745765ac7daec95c01/blob/src/macros.jl#L839

The Ref was added here:
https://github.com/jump-dev/JuMP.jl/pull/1438/files#diff-e628f2d30670b1af0cdd9c9c520aaddc44021cd503e169d767ec49c95f189264R288

I guess because we didn't yet have:
jump-dev/MathOptInterface.jl@ed08ee9

I think it's because only the .∈ syntax supports this. You can't . the in-fix in operator:

julia> dump(:(x .in y))
ERROR: syntax: space before "." not allowed in "x ." at REPL[76]:1
Stacktrace:
 [1] top-level scope
   @ none:1

julia> dump(:(x in. y))
ERROR: syntax: invalid identifier name "."
Stacktrace:
 [1] top-level scope
   @ none:1

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2896184) 98.22% compared to head (d6fc941) 98.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3632      +/-   ##
==========================================
+ Coverage   98.22%   98.24%   +0.01%     
==========================================
  Files          43       43              
  Lines        5636     5636              
==========================================
+ Hits         5536     5537       +1     
+ Misses        100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 817dc13 into master Dec 18, 2023
11 checks passed
@odow odow deleted the od/constrainnt-broadcast branch December 18, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant