-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable integer_atomics feature for Atomic*128 #15
Conversation
Huh, this is curious. |
I believe the root cause is that the
|
Thanks! I think I'm slowly understanding what's happening - the There are two possibilities now. a) Your code clearly fixes the issue by enabling the feature if needed (I misread the change earlier) |
This comment was marked as outdated.
This comment was marked as outdated.
@kcking Could you check that this version now works for you (also if you actually use an Atomic[I|U]128 type)? |
I am actually only using this crate transitively through rust-cuda, in my test case I'm using AtomicU64 and windows. Replacing rust-cuda's version of this crate with cc94bc8 works for me! (I can't test AtomicU128 with rust-cuda as I don't think rust ptx has Atomic*128 support). |
Proposing this change as it fixed the build of rust-cuda for me on windows with rustc
channel = "nightly-2024-07-21"
, though I am not sure if there is a more correct way to solve this.