Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): Add support for --incompatible_disallow_empty_glob #715

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
build:asan --strip=never
# Make globs that don't match anything fail
common --incompatible_disallow_empty_glob

build:asan --strip=never
build:asan --copt -fsanitize=address
build:asan --copt -DADDRESS_SANITIZER
build:asan --copt -O0
build:asan --copt -fno-omit-frame-pointer
build:asan --copt -g
build:asan --linkopt -fsanitize=address
build:asan --linkopt -fsanitize=address
build:asan --cc_output_directory_tag=asan

build:ssl --define=with_civetweb_ssl=true
12 changes: 0 additions & 12 deletions pull/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,3 @@ cc_library(
"@zlib",
],
)

cc_library(
name = "pull_internal_headers",
hdrs = glob(
["src/detail/*.h"],
),
strip_include_prefix = "src",
visibility = ["//pull/tests:__subpackages__"],
deps = [
"//core",
],
)
5 changes: 1 addition & 4 deletions pull/tests/unit/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
cc_test(
name = "unit",
srcs = glob([
"*.cc",
"*.h",
]),
srcs = glob(["*.cc"]),
copts = ["-Iexternal/googletest/include"],
linkstatic = True,
deps = [
Expand Down
5 changes: 1 addition & 4 deletions push/tests/internal/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
cc_test(
name = "internal",
srcs = glob([
"*.cc",
"*.h",
]),
srcs = glob(["*.cc"]),
copts = ["-Iexternal/googletest/include"],
linkstatic = True,
deps = [
Expand Down
8 changes: 1 addition & 7 deletions util/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
cc_library(
name = "util",
srcs = glob([
"src/**/*.cc",
"src/**/*.h",
]),
hdrs = glob(
["include/**/*.h"],
),
hdrs = glob(["include/**/*.h"]),
strip_include_prefix = "include",
visibility = ["//:__subpackages__"],
)
5 changes: 1 addition & 4 deletions util/tests/unit/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
cc_test(
name = "unit",
srcs = glob([
"*.cc",
"*.h",
]),
srcs = glob(["*.cc"]),
copts = ["-Iexternal/googletest/include"],
linkstatic = True,
deps = [
Expand Down
Loading