-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⏩ Use vite instead of Remix Classic Compiler (3) #410
base: agoose77/feat-use-v2
Are you sure you want to change the base?
Conversation
This snapshot "works", but the static deployment is broken. I need to figure out the following:
This is all confusing stuff; there are so many interacting layers. But I think that's mainly a function of my knowledge rather than the problem at large. |
So it looks like the v1-v2 routing thing was maybe a fluke? I sat back down to the branch today and it broke the navigation. Without that change, navigation and link-intent from non-index pages works, but the index seems to trigger a reload. |
f722b64
to
6881436
Compare
Looks like the redirect phenomenon is actually |
This PR works towards using Vite instead of the Remix Classic Compiler. From reading, it seems like only Vite supports changing the base path, which I think is a required solution to the v2 redirect problem (actually serve the theme from the base path it will be served from)
As this is an iterative PR, here are some findings: