Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©β€πŸ”¬ Only add affiliations associated with authors to JATS and myst-templates #662

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Oct 13, 2023

This addresses the issues in #659 without fundamental changes to frontmatter.

@rowanc1 rowanc1 changed the title Only add affiliations associated with authors to JATS and myst-templates πŸ‘©β€πŸ”¬ Only add affiliations associated with authors to JATS and myst-templates Oct 13, 2023
Comment on lines -227 to 224
if (otherContribs.length) {
contribGroups.push({ type: 'element', name: 'contrib-group', elements: otherContribs });
}
return contribGroups;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can bring something else back when we do "editors" etc.

@rowanc1
Copy link
Member

rowanc1 commented Oct 13, 2023

Tested against both JATS and PDF, both look good!

@rowanc1 rowanc1 merged commit d25debf into main Oct 13, 2023
3 checks passed
@rowanc1 rowanc1 deleted the feat/filter-aff branch October 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants