Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jupyter client < 8 #378

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

kevin-bates
Copy link
Member

In toubleshooting #376, it was clear we need to pin (cap) the jupyter_client package < 8. This pull request also includes the following:

  1. Adds a better default log format that includes color encodings and timestamps to the millisecond (same as JEG)
  2. Adds the JKG version to the startup message (same as JEG)
$ jupyter kernelgateway --KernelGatewayApp.api=kernel_gateway.notebook_http --KernelGatewayApp.seed_uri=/Users/kbates/jkg-example.ipynb --port=10100       
[I 2023-02-06 10:49:34.739 KernelGatewayApp] Kernel started: 81225f93-44df-484c-89cb-96d0fbbc7c26, name: python3
[I 2023-02-06 10:49:35.647 KernelGatewayApp] Registering resource: /hello/world, methods: (['GET'])
[I 2023-02-06 10:49:35.647 KernelGatewayApp] Registering resource: /_api/spec/swagger.json, methods: (GET)
[I 2023-02-06 10:49:35.655 KernelGatewayApp] Jupyter Kernel Gateway 2.6.0.dev0 is available at http://127.0.0.1:10100
  1. Removes Python 3.6 from the CI matrix and set of supported python versions.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 95.69% // Head: 95.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fb34792) compared to base (c72803a).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          31       31           
  Lines        2251     2255    +4     
=======================================
+ Hits         2154     2158    +4     
  Misses         97       97           
Impacted Files Coverage Δ
kernel_gateway/tests/test_jupyter_websocket.py 99.45% <ø> (ø)
kernel_gateway/gatewayapp.py 84.21% <83.33%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevin-bates kevin-bates merged commit 146c10d into jupyter-server:master Feb 6, 2023
@kevin-bates kevin-bates deleted the pin-jupyter_client branch February 6, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant