Revert PR #378 (Simplify NotebookNotary._data_dir_default) #397
Conversation
There was a problem hiding this comment.
I'm 👍 to reverting this for another patch release, since we currently have the latest patch release introducing this change, but I'd like to keep #396 open to think through alternatives or improvements. It just doesn't feel good to instantiate an app just for this one directory in cases where the NotebookNotary is being used by itself.
There was a problem hiding this comment.
Sorry, can we take this file with whitespace changes out? it wasn't there in #378.
There was a problem hiding this comment.
I did not make this, it was the precommit bot. I'm afraid I do not have permissions to override the bot
There was a problem hiding this comment.
I'm sorry about that, @krassowski <3
Nevermind that last part, the only remaining issue belongs in jupyter_core, so I opened jupyter/jupyter_core#397 |
|
Thanks for the merge! Another downstream affected: widgetti/ipyvuetify#301 @blink1073 a new patch release would be highly valued (once you have time to look at it) |
|
Done! |
|
Thank you! |
Reverts #378 to close #396.
This is because the breakage was also reported in the wild, see: