Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section to use local dependencies #7292

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Mar 11, 2024

Add a section in contributing documentation that provides a solution to use local dependencies.

Related to #6392

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/notebook/yalc_documentation

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet!

I left couple of minor wording comments, otherwise looks good 👍

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
brichet and others added 5 commits March 11, 2024 15:14
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
@jtpio jtpio added this to the 7.1.x milestone Mar 11, 2024
@jtpio
Copy link
Member

jtpio commented Mar 11, 2024

The check release failure should be fixed in #7291 (removing the use of --pre when install jupyterlab).

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 2c95b1b into jupyter:main Mar 11, 2024
29 of 31 checks passed
@brichet brichet deleted the yalc_documentation branch March 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants