Explicitly set allValues for hub variable
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, on latest grafana, the dashboards will currently show 'no data' because the `$hub` variable is not set correctly (see 2i2c-org/infrastructure#3237 for details). The longer term solution to this is: 1. Move away from the deprecated graphPanel to timeseries objects for panel 2. jupyterhub#89 Both of these are being undertaken in jupyterhub#90, but in the meantime, this PR implements [this workaround](jupyterhub#90) so end users can at least see data.
consideRatio
approved these changes
Oct 19, 2023
|
Is this to be considered a bugfix perhaps? |
yuvipanda
added a commit
to yuvipanda/grafana-dashboards
that referenced
this pull request
Feb 29, 2024
A follow-up to jupyterhub#91, as the openscapes community reported this is causing issues not just for the $hub variable but everything else as well. jupyterhub#90 is the long term fix
yuvipanda
added a commit
to yuvipanda/grafana-dashboards
that referenced
this pull request
Jul 25, 2024
A follow-up to jupyterhub#91, as the openscapes community reported this is causing issues not just for the $hub variable but everything else as well. jupyterhub#90 is the long term fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on latest grafana, the dashboards will currently show 'no data' because the
$hubvariable is not set correctly (see 2i2c-org/infrastructure#3237 for details). The longer term solution to this is:Both of these are being undertaken in
#90, but in the meantime, this PR implements
this
workaround so end users can at least see data.