Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 7.0.0 #866

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add changelog for 7.0.0 #866

merged 2 commits into from
Oct 25, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 21, 2024

I'm trying to tie up things for z2jh 4, but I'm not sure if kubespawner is ready yet. Should kubespawner 7 include upgrade docs on things that z2jh references with regards to the new default slug scheme?

@manics @minrk overall I feel my momentum run low with z2jh 4 release efforts, but I think what remains is upgrade related docs and possibly jupyterhub/zero-to-jupyterhub-k8s#3548

@minrk
Copy link
Member

minrk commented Oct 21, 2024

Thanks for leading this! I have a lot until Thursday, but I will try to help finish this this week. I think it's ready after the testing we have done, but will at least do a pass on docs.

@minrk
Copy link
Member

minrk commented Oct 24, 2024

Done with my big things this week, coming back to this. We do have upgrade docs here for the template scheme and they are linked from the changelog , which I think is sufficient. So I think we're good to go here. Anything more you want to do?

@minrk
Copy link
Member

minrk commented Oct 24, 2024

I realized I missed the z2jh-specific question, and no, I don't think these docs should reference the chart. I added the z2jh part in jupyterhub/zero-to-jupyterhub-k8s#3557

@manics
Copy link
Member

manics commented Oct 24, 2024

Can we get one more fix in? Should be straightforward:
#868

@minrk
Copy link
Member

minrk commented Oct 24, 2024

Yeah, no problem

@minrk
Copy link
Member

minrk commented Oct 25, 2024

updated with #869, ok to merge and release?

@@ -6,7 +6,7 @@

## 7.0

### [7.0.0] - 2024-10-21
### [7.0.0] - 2024-10-25

([full changelog](https://github.com/jupyterhub/kubespawner/compare/6.2.0...7.0.0))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had kubespawner upgrade docs, lets link to them here as well.

Lgtm otherwise, i'm walking about with family atm so if someone wants please feel free to finalize this and do a release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, trying to figure out how I lost them. I'll put it back. Thanks for noticing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I didn't lose them. They are right below in the breaking changes. So the link is there and near the top. I think that is sufficient. I'll go ahead and make the release.

@minrk minrk merged commit 40eb989 into jupyterhub:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planning release of v7
3 participants