-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 7.0.0 #866
Conversation
Thanks for leading this! I have a lot until Thursday, but I will try to help finish this this week. I think it's ready after the testing we have done, but will at least do a pass on docs. |
Done with my big things this week, coming back to this. We do have upgrade docs here for the template scheme and they are linked from the changelog , which I think is sufficient. So I think we're good to go here. Anything more you want to do? |
I realized I missed the z2jh-specific question, and no, I don't think these docs should reference the chart. I added the z2jh part in jupyterhub/zero-to-jupyterhub-k8s#3557 |
Can we get one more fix in? Should be straightforward: |
Yeah, no problem |
updated with #869, ok to merge and release? |
@@ -6,7 +6,7 @@ | |||
|
|||
## 7.0 | |||
|
|||
### [7.0.0] - 2024-10-21 | |||
### [7.0.0] - 2024-10-25 | |||
|
|||
([full changelog](https://github.com/jupyterhub/kubespawner/compare/6.2.0...7.0.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had kubespawner upgrade docs, lets link to them here as well.
Lgtm otherwise, i'm walking about with family atm so if someone wants please feel free to finalize this and do a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, trying to figure out how I lost them. I'll put it back. Thanks for noticing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't lose them. They are right below in the breaking changes. So the link is there and near the top. I think that is sufficient. I'll go ahead and make the release.
I'm trying to tie up things for z2jh 4, but I'm not sure if kubespawner is ready yet. Should kubespawner 7 include upgrade docs on things that z2jh references with regards to the new default slug scheme?
@manics @minrk overall I feel my momentum run low with z2jh 4 release efforts, but I think what remains is upgrade related docs and possibly jupyterhub/zero-to-jupyterhub-k8s#3548