Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty command #133

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix empty command #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3ef49b
Fix empty command
krassowski Jan 29, 2024
2831da3
Fix a typo in command name
krassowski Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schema/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
{
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'][data-jp-vim-shift-esc-override-browser='true'] .jp-Notebook.jp-mod-commandMode",
"keys": ["Shift Escape"],
"command": ""
"command": "vim:no-action"
},
{
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
Expand Down
10 changes: 9 additions & 1 deletion src/labCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export function addNotebookCommands(
isEnabled
}),
commands.addCommand('vim:leave-current-mode', {
label: 'Move Insert to Normal to Jupyter Command Mode"',
label: 'Move Insert to Normal to Jupyter Command Mode',
execute: args => {
const current = getCurrent(args);

Expand Down Expand Up @@ -284,6 +284,14 @@ export function addNotebookCommands(
}
},
isEnabled
}),
commands.addCommand('vim:no-action', {
label: 'Prevent Default Browser Action',
caption:
'Prevent default action for some keybindings (defined in the settings); for example Firefox binds Shift + Esc to its Process Manager which conflicts with the expected action in the vim mode.',
execute: args => {
// no-op
}
})
];
return addedCommands;
Expand Down
Loading