Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated settings panel #35

Open
brichet opened this issue Feb 7, 2025 · 6 comments · May be fixed by #48
Open

Add a dedicated settings panel #35

brichet opened this issue Feb 7, 2025 · 6 comments · May be fixed by #48
Assignees
Labels
enhancement New feature or request

Comments

@brichet
Copy link
Collaborator

brichet commented Feb 7, 2025

Problem

Each provider has its own settings in @langchainjs.
Therefore, we need to update manually the settings when changing the provider.

Proposed Solution

Have a dedicated AI settings panel that does not use the Jupyterlab settings system, to give more flexibility.

Additional context

Discussion started at #27 (comment)

@brichet brichet added the enhancement New feature or request label Feb 7, 2025
@brichet brichet mentioned this issue Feb 7, 2025
@jtpio
Copy link
Member

jtpio commented Feb 7, 2025

Maybe it could be worth having a UI similar to what jupyter-ai provides. So the settings can be discovered via the chat panel.

Not sure how reusable the jupyter-ai components are though at the moment.

@jtpio
Copy link
Member

jtpio commented Feb 7, 2025

Also a dedicated panel would help have better control on the persistence of secrets such as API keys and allow for temporary secrets valid until the next page refresh. Instead of relying on the settings which get stored in the browser in the case of JupyterLite, on the server for JupyterLab.

@jtpio
Copy link
Member

jtpio commented Feb 10, 2025

Also opened #37, which could be done after the move to a proper panel.

The plugin providing the settings panel could then depend on the plugin providing the secrets manager.

@jtpio
Copy link
Member

jtpio commented Feb 16, 2025

Maybe a good starting point could be to have something similar to what Jupyter AI does in the upcoming v3 version (or even reuse some parts of it if possible):

Image

@jtpio
Copy link
Member

jtpio commented Feb 16, 2025

Also maybe it could be useful to provide instructions for using the model in the settings panel directly.

For now the README has some information about some of the models, but it could be more practical to put that information somewhere in the settings panel directly (or hidden by default, but can be displayed easily).

For example in the case of ChromeAI that would allow putting links to access and enable the required flags.

@brichet
Copy link
Collaborator Author

brichet commented Feb 17, 2025

Also maybe it could be useful to provide instructions for using the model in the settings panel directly.

For now the README has some information about some of the models, but it could be more practical to put that information somewhere in the settings panel directly (or hidden by default, but can be displayed easily).

For example in the case of ChromeAI that would allow putting links to access and enable the required flags.

Right, this helper could be updated when changing the provider.

I'll try to start that settings panel soon.

@brichet brichet self-assigned this Feb 19, 2025
@brichet brichet linked a pull request Feb 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants