Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI improvement #48

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Feb 19, 2025

Fixes #35

record-2025-02-20_18.17.07.webm

This PR uses a react component in the settings panel, to make it more reactive and configurable.
With this new setting component:

  • settings are saved for each provider, and restored when loading the page again (use local storage)
  • the field containing the word 'key' are replaced by a password widget

It also use a simpler way to import generated schema, no need to set it up manually when adding a new provider.

@brichet brichet added the enhancement New feature or request label Feb 19, 2025
@brichet brichet marked this pull request as ready for review February 20, 2025 17:24
@brichet brichet changed the title Settings with a custom react component Settings UI improvement Feb 20, 2025
@brichet
Copy link
Collaborator Author

brichet commented Feb 20, 2025

This PR is missing some helpers about the use of each provider, as described in #35 (comment).

Since this is using a FormComponent, helper could easily be included above or below it.
A better user experience could be to include it between the provider select and the dynamic settings. This option needs some refactoring to split the form, and include the helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dedicated settings panel
1 participant