Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic compatibily with Omega #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maghiel
Copy link

@maghiel maghiel commented May 4, 2024

I took work from https://forum.kodi.tv/archive/index.php?thread-375914-2.html, implemented it partly and improved on it a bit.
(So I no way do I take credit for the great work done!)

Same with linked:

  • Updated xmbc.gui version in addon.xml

Differences with linked:

  • Instead of replacing DialogFavourites.xml with MyFavourites.xml I opted to add MyFavourites.xml

Improvements:

  • Added Favourites as default skin menu item
  • Override Favourites in Common > Favourites to use Favouritesbrowser

Disclaimer:

  • Again, in no way do I want to take credit for the great work already done and which I could build from.
  • I am not a skinner, nor experienced in skinning. I just love Eminence, and missed it like a lot of people do.

Todo:
The Favourites menu needs skinning! Help :)

@FAUVEisEditing
Copy link

FAUVEisEditing commented Aug 30, 2024

Still not working for me T_T (installation by Zip), error : Dependency of xbmc.gui 5.15.0 is missing
will try to edit import addon="xbmc.gui" version="5.15.0" /> to <import addon="xbmc.gui" version="5.17.0" as mentionend, thx

@maghiel
Copy link
Author

maghiel commented Aug 30, 2024

Still not working for me T_T (installation by Zip), error : Dependency of xbmc.gui 5.15.0 is missing will try to edit import addon="xbmc.gui" version="5.15.0" /> to <import addon="xbmc.gui" version="5.17.0" as mentionend, thx

@FAUVEisEditing this is an open pull request as this repository is no longer maintained(correct me if I'm wrong). Did you download the zip here or at my fork? https://github.com/maghiel/skin.eminence.2/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants