Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor #68

wants to merge 3 commits into from

Conversation

Shivam25092001
Copy link
Contributor

@Shivam25092001 Shivam25092001 commented Aug 9, 2024 •
edited
Loading

ADDED

  • Added util getDictFromArray and function getIndexZeroAndApplyTransform in Redirect.res to eliminate code repetition.
  • Added support for input type BlikCode.

CHANGED

  • Changed input field type form string to enum of type Email | Country | Name | Bank | BlikCode.

REFACTORED

  • added seperate file ProcessPaymentRequest and moved in functions like processRequestWallet, processRequestCrypto, processRequest, etc. that generates body for confirm call & performs action according to the response.
  • move confirm gpay, paypal, applepay callbacks from Redirect.res to processRequestWallet.

FIXED

  • incorrect confirm body being sent in payments that required selectedBank, country, name, blikCode, etc.

@Shivam25092001 Shivam25092001 mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashu331998 aashu331998 Awaiting requested review from aashu331998

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shivam25092001