Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: handle redirections for iframed content #557

Merged
merged 7 commits into from
Sep 10, 2024
Merged

refactor: handle redirections for iframed content #557

merged 7 commits into from
Sep 10, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Aug 12, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

How did you test it?

Tested payment and payout links locally

[Payments] open links (no auth redirections)
Screen.Recording.2024-08-12.at.1.53.41.PM.mov
[Payments] open links (with auth redirections)
Screen.Recording.2024-08-12.at.1.54.19.PM.mov
[Payments] secure links (no auth redirections)
Screen.Recording.2024-08-12.at.1.52.21.PM.mov
[Payments] secure links (with auth redirections)
Screen.Recording.2024-08-12.at.1.49.31.PM.mov
[Payouts] secure links (with status page redirection)
Screen.Recording.2024-08-12.at.1.55.23.PM.mov

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Aug 12, 2024
@kashif-m kashif-m changed the title Iframe redirections refactor: handle redirections for iframed content Aug 12, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Aug 12, 2024
@kashif-m kashif-m self-assigned this Aug 12, 2024
@kashif-m kashif-m marked this pull request as ready for review August 13, 2024 09:09
seekshiva
seekshiva requested changes Sep 6, 2024
View reviewed changes
src/Window.res Show resolved Hide resolved
@seekshiva seekshiva merged commit b819da0 into main Sep 10, 2024
3 checks passed
@seekshiva seekshiva deleted the iframe-redirections branch September 10, 2024 11:30
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Sep 10, 2024
ArushKapoorJuspay added a commit that referenced this pull request Sep 13, 2024
@ArushKapoorJuspay
revert: handle redirections for iframed content (#557)
26980f5
@ArushKapoorJuspay ArushKapoorJuspay mentioned this pull request Sep 13, 2024
Merged
11 tasks
seekshiva pushed a commit that referenced this pull request Sep 13, 2024
@ArushKapoorJuspay
revert: handle redirections for iframed content (#557) (#611)
6e203e4
akash-c-k pushed a commit that referenced this pull request Sep 13, 2024
@semantic-release-bot
chore(release): 0.86.1 [skip ci]
477effc 
## [0.86.1](v0.86.0...v0.86.1) (2024-09-13)

### Reverts

* handle redirections for iframed content ([#557](#557)) ([#611](#611)) ([6e203e4](6e203e4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva seekshiva approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@kashif-m kashif-m

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashif-m @seekshiva @PritishBudhiraja