Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added nested iframe test support in cypress and external 3ds ne… #764

Merged
merged 2 commits into from
Nov 7, 2024
Merged

test: added nested iframe test support in cypress and external 3ds ne… #764

merged 2 commits into from
Nov 7, 2024

Conversation

Sanskar2001
Copy link
Contributor

…tcetera test case

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added nested iframe test support in cypress and external 3ds netcetera test case

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 4, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/utils.ts  40% smaller
  cypress-tests/cypress/e2e/external-3DS-netcetera-e2e-test.cy.ts  0% smaller
  cypress-tests/cypress/support/commands.ts  0% smaller
  cypress-tests/cypress/support/types.ts  0% smaller

@PritishBudhiraja PritishBudhiraja changed the title feat: added nested iframe test support in cypress and external 3ds ne… test: added nested iframe test support in cypress and external 3ds ne… Nov 4, 2024
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. TypeScript Language Required to solve the issue Testing Add this label if the PR contains Testing related changes labels Nov 4, 2024
@PritishBudhiraja PritishBudhiraja merged commit d24954a into main Nov 7, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the nested-iframe-testing branch November 7, 2024 07:16
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. TypeScript Language Required to solve the issue Testing Add this label if the PR contains Testing related changes labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seekshiva seekshiva seekshiva approved these changes

Assignees

@Sanskar2001 Sanskar2001

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sanskar2001 @seekshiva @PritishBudhiraja