-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: premount loader - 2 #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pritish Budhiraja <[email protected]>
…r-premount-loader
PritishBudhiraja
requested review from
seekshiva and
ArushKapoorJuspay
as code owners
November 6, 2024 02:28
PritishBudhiraja
temporarily deployed
to
Testing
November 6, 2024 02:28
— with
GitHub Actions
Inactive
PritishBudhiraja
temporarily deployed
to
Testing
November 6, 2024 02:32
— with
GitHub Actions
Inactive
PritishBudhiraja
added
Enhancement / Refactoring
New feature or request or any refactoring
Ready for Review
PR with label Ready for Review should only be reviewed.
labels
Nov 6, 2024
…r-premount-loader-2
PritishBudhiraja
temporarily deployed
to
Testing
November 6, 2024 10:02
— with
GitHub Actions
Inactive
PritishBudhiraja
temporarily deployed
to
Testing
November 6, 2024 15:04
— with
GitHub Actions
Inactive
PritishBudhiraja
temporarily deployed
to
Testing
November 6, 2024 15:06
— with
GitHub Actions
Inactive
seekshiva
requested changes
Nov 7, 2024
…r-premount-loader-2
…witch-web into refactor-premount-loader-2
PritishBudhiraja
temporarily deployed
to
Testing
November 7, 2024 06:27
— with
GitHub Actions
Inactive
PritishBudhiraja
temporarily deployed
to
Testing
November 7, 2024 06:32
— with
GitHub Actions
Inactive
seekshiva
approved these changes
Nov 7, 2024
github-actions
bot
added
Closed
Label will be automatically added when the PR will get merged to main
and removed
Enhancement / Refactoring
New feature or request or any refactoring
Ready for Review
PR with label Ready for Review should only be reviewed.
labels
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactoring Pre mount loader part - 2
How did you test it?
Code compiling and more test cases
Checklist
npm run re:build