Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test card payment with multiple card brands #825

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: test card payment with multiple card brands #825

wants to merge 5 commits into from

Conversation

aritro2002
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add automated Cypress tests to validate the card number length for various card brands, ensuring support for lengths of 14, 15, 16, and 19 digits.

How did you test it?

Screenshot 2024-12-09 at 1 14 05 PM I have tested in card-validation branch.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@aritro2002 aritro2002 added Ready for Review PR with label Ready for Review should only be reviewed. Testing Add this label if the PR contains Testing related changes labels Dec 9, 2024
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 9, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/cards.ts  7% smaller
  cypress-tests/cypress/e2e/multiple-card-test.cy.ts  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@Sanskar2001 Sanskar2001 Awaiting requested review from Sanskar2001 Sanskar2001 is a code owner

@PritishBudhiraja PritishBudhiraja Awaiting requested review from PritishBudhiraja

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay

At least 2 approving reviews are required to merge this pull request.

Assignees

@aritro2002 aritro2002

Labels
Ready for Review PR with label Ready for Review should only be reviewed. Testing Add this label if the PR contains Testing related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aritro2002 @PritishBudhiraja