Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added eslint config for promise catch handling #871

Merged
merged 5 commits into from
Jan 21, 2025
Merged

feat: added eslint config for promise catch handling #871

merged 5 commits into from
Jan 21, 2025

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

So we are having multiple catch blocks which are not handled properly. Need to fix this

How did you test it?

Locally building and running it.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Development In Progress Use this label if you have raised the PR but development is still under progress label Jan 16, 2025
@PritishBudhiraja PritishBudhiraja self-assigned this Jan 16, 2025
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 16, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  67% smaller
  .eslintrc.json  58% smaller
  package-lock.json Unsupported file format
  src/LoaderController.res Unsupported file format
  src/PaymentMethodCollectElement.res Unsupported file format
  src/Payments/ApplePay.res Unsupported file format
  src/Payments/PayPal.res Unsupported file format
  src/Payments/PaypalSDKHelpers.res Unsupported file format
  src/Utilities/PaymentHelpers.res Unsupported file format
  src/hyper-loader/Elements.res Unsupported file format
  src/hyper-loader/Hyper.res Unsupported file format
  src/hyper-loader/LoaderPaymentElement.res Unsupported file format
  src/hyper-loader/PaymentMethodsManagementElements.res Unsupported file format
  src/hyper-loader/PaymentSessionMethods.res Unsupported file format

@aritro2002 @sakksham7
fix: add catch block (#873)
74d524a 
Co-authored-by: Saksham Sharma <[email protected]>
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. and removed Development In Progress Use this label if you have raised the PR but development is still under progress labels Jan 17, 2025
seekshiva
seekshiva previously approved these changes Jan 21, 2025
View reviewed changes
sakksham7
sakksham7 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sakksham7 sakksham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. 😇

@PritishBudhiraja PritishBudhiraja merged commit f03787a into main Jan 21, 2025
3 of 4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the catch-block-handling branch January 21, 2025 07:21
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Jan 21, 2025
PritishBudhiraja pushed a commit that referenced this pull request Jan 21, 2025
@semantic-release-bot
chore(release): 0.109.0 [skip ci]
6341978 
# [0.109.0](v0.108.0...v0.109.0) (2025-01-21)

### Features

* added eslint config for promise catch handling ([#871](#871)) ([f03787a](f03787a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aritro2002 aritro2002 aritro2002 approved these changes

@sakksham7 sakksham7 sakksham7 approved these changes

@seekshiva seekshiva seekshiva approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@PritishBudhiraja PritishBudhiraja

@sakksham7 sakksham7

@aritro2002 aritro2002

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PritishBudhiraja @seekshiva @sakksham7 @aritro2002