chore: use generic phone numbers instead (#5142)

juspay · Jun 27, 2024 · 57055ec · 57055ec
1 parent d4dba55
commit 57055ec
Show file tree

Hide file tree

Showing 144 changed files with 420 additions and 420 deletions.
diff --git a/.github/testcases/ui_tests.json b/.github/testcases/ui_tests.json
diff --git a/api-reference/openapi_spec.json b/api-reference/openapi_spec.json
@@ -59,7 +59,7 @@
                       },
                       "phone": {
                         "country_code": "+91",
-                        "number": "8056594427"
+                        "number": "9123456789"
                       }
                     },
                     "currency": "USD",
@@ -107,7 +107,7 @@
                       "email": "[email protected]",
                       "id": "cus_abcdefgh",
                       "name": "John Dough",
-                      "phone": "9999999999"
+                      "phone": "9123456789"
                     },
                     "description": "Its my first payment request",
                     "metadata": {
@@ -254,7 +254,7 @@
                       },
                       "phone": {
                         "country_code": "+91",
-                        "number": "8056594427"
+                        "number": "9123456789"
                       }
                     }
                   }
@@ -8481,7 +8481,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 10
           },
@@ -8524,7 +8524,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 10
           },
@@ -8733,7 +8733,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "9999999999",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -8797,7 +8797,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "9999999999",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -10686,7 +10686,7 @@
           "phone_number": {
             "type": "string",
             "description": "The telephone number for Japanese convenience stores",
-            "example": "9999999999",
+            "example": "9123456789",
             "nullable": true
           }
         }
@@ -15647,7 +15647,7 @@
             "type": "string",
             "description": "The customer's phone number\nThis field will be deprecated soon, use the customer object instead",
             "deprecated": true,
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -16184,7 +16184,7 @@
             "type": "string",
             "description": "The customer's phone number\nThis field will be deprecated soon. Please refer to `customer.phone` object",
             "deprecated": true,
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -17222,7 +17222,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -17401,7 +17401,7 @@
           "phone": {
             "type": "string",
             "description": "The customer's phone number",
-            "example": "3141592653",
+            "example": "9123456789",
             "nullable": true,
             "maxLength": 255
           },
@@ -17929,7 +17929,7 @@
           "number": {
             "type": "string",
             "description": "The contact number",
-            "example": "9999999999",
+            "example": "9123456789",
             "nullable": true
           },
           "country_code": {
@@ -19312,7 +19312,7 @@
           },
           "bic": {
             "type": "string",
-            "example": "1024419982"
+            "example": "9123456789"
           },
           "country": {
             "type": "string"

diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs
@@ -22,7 +22,7 @@ pub struct CustomerRequest {
     #[schema(value_type = Option<String>, max_length = 255, example = "[email protected]")]
     pub email: Option<pii::Email>,
     /// The customer's phone number
-    #[schema(value_type = Option<String>, max_length = 255, example = "9999999999")]
+    #[schema(value_type = Option<String>, max_length = 255, example = "9123456789")]
     pub phone: Option<Secret<String>>,
     /// An arbitrary string that you can attach to a customer object.
     #[schema(max_length = 255, example = "First Customer")]
@@ -52,7 +52,7 @@ pub struct CustomerResponse {
     #[schema(value_type = Option<String>,max_length = 255, example = "[email protected]")]
     pub email: crypto::OptionalEncryptableEmail,
     /// The customer's phone number
-    #[schema(value_type = Option<String>,max_length = 255, example = "9999999999")]
+    #[schema(value_type = Option<String>,max_length = 255, example = "9123456789")]
     pub phone: crypto::OptionalEncryptablePhone,
     /// The country code for the customer phone number
     #[schema(max_length = 255, example = "+65")]

diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
@@ -194,7 +194,7 @@ pub struct CustomerDetails {
     pub email: Option<Email>,
 
     /// The customer's phone number
-    #[schema(value_type = Option<String>, max_length = 10, example = "3141592653")]
+    #[schema(value_type = Option<String>, max_length = 10, example = "9123456789")]
     pub phone: Option<Secret<String>>,
 
     /// The country code for the customer's phone number
@@ -217,7 +217,7 @@ pub struct CustomerDetailsResponse {
     pub email: Option<Email>,
 
     /// The customer's phone number
-    #[schema(value_type = Option<String>, max_length = 10, example = "3141592653")]
+    #[schema(value_type = Option<String>, max_length = 10, example = "9123456789")]
     pub phone: Option<Secret<String>>,
 
     /// The country code for the customer's phone number
@@ -321,7 +321,7 @@ pub struct PaymentsRequest {
 
     /// The customer's phone number
     /// This field will be deprecated soon, use the customer object instead
-    #[schema(value_type = Option<String>, max_length = 255, example = "3141592653", deprecated)]
+    #[schema(value_type = Option<String>, max_length = 255, example = "9123456789", deprecated)]
     #[remove_in(PaymentsUpdateRequest, PaymentsCreateRequest, PaymentsConfirmRequest)]
     pub phone: Option<Secret<String>>,
 
@@ -2136,7 +2136,7 @@ pub struct JCSVoucherData {
     #[schema(value_type = Option<String>, example = "[email protected]")]
     pub email: Option<Email>,
     /// The telephone number for Japanese convenience stores
-    #[schema(value_type = Option<String>, example = "9999999999")]
+    #[schema(value_type = Option<String>, example = "9123456789")]
     pub phone_number: Option<String>,
 }
 
@@ -3013,7 +3013,7 @@ impl AddressDetails {
 #[derive(Debug, Clone, Default, Eq, PartialEq, ToSchema, serde::Deserialize, serde::Serialize)]
 pub struct PhoneDetails {
     /// The contact number
-    #[schema(value_type = Option<String>, example = "9999999999")]
+    #[schema(value_type = Option<String>, example = "9123456789")]
     pub number: Option<Secret<String>>,
     /// The country code attached to the number
     #[schema(example = "+1")]
@@ -3234,7 +3234,7 @@ pub enum BankTransferInstructions {
 pub struct SepaBankTransferInstructions {
     #[schema(value_type = String, example = "Jane Doe")]
     pub account_holder_name: Secret<String>,
-    #[schema(value_type = String, example = "1024419982")]
+    #[schema(value_type = String, example = "9123456789")]
     pub bic: Secret<String>,
     pub country: String,
     #[schema(value_type = String, example = "123456789")]
@@ -3447,7 +3447,7 @@ pub struct PaymentsResponse {
 
     /// The customer's phone number
     /// This field will be deprecated soon. Please refer to `customer.phone` object
-    #[schema(value_type = Option<String>, max_length = 255, example = "3141592653", deprecated)]
+    #[schema(value_type = Option<String>, max_length = 255, example = "9123456789", deprecated)]
     pub phone: crypto::OptionalEncryptablePhone,
 
     /// The URL to redirect after the completion of the operation

diff --git a/crates/api_models/src/payouts.rs b/crates/api_models/src/payouts.rs
@@ -81,7 +81,7 @@ pub struct PayoutCreateRequest {
             "first_name": "John",
             "last_name": "Doe"
         },
-        "phone": { "number": "8056594427", "country_code": "+1" }
+        "phone": { "number": "9123456789", "country_code": "+1" }
     }"#))]
     pub billing: Option<payments::Address>,
 
@@ -102,7 +102,7 @@ pub struct PayoutCreateRequest {
     pub name: Option<Secret<String>>,
 
     /// The customer's phone number
-    #[schema(value_type = Option<String>, max_length = 255, example = "3141592653")]
+    #[schema(value_type = Option<String>, max_length = 255, example = "9123456789")]
     pub phone: Option<Secret<String>>,
 
     /// The country code for the customer phone number
@@ -393,7 +393,7 @@ pub struct PayoutCreateResponse {
             "first_name": "John",
             "last_name": "Doe"
         },
-        "phone": { "number": "8056594427", "country_code": "+1" }
+        "phone": { "number": "9123456789", "country_code": "+1" }
     }"#))]
     pub billing: Option<payments::Address>,
 
@@ -414,7 +414,7 @@ pub struct PayoutCreateResponse {
     pub name: crypto::OptionalEncryptableName,
 
     /// The customer's phone number
-    #[schema(value_type = Option<String>, max_length = 255, example = "3141592653")]
+    #[schema(value_type = Option<String>, max_length = 255, example = "9123456789")]
     pub phone: crypto::OptionalEncryptablePhone,
 
     /// The country code for the customer phone number

diff --git a/crates/cards/src/validate.rs b/crates/cards/src/validate.rs
@@ -243,7 +243,7 @@ mod tests {
 
     #[test]
     fn test_invalid_card_number_masking() {
-        let secret: Secret<String, CardNumberStrategy> = Secret::new("1234567890".to_string());
+        let secret: Secret<String, CardNumberStrategy> = Secret::new("9123456789".to_string());
         assert_eq!("*** alloc::string::String ***", format!("{secret:?}"));
     }
 

diff --git a/crates/common_utils/src/pii.rs b/crates/common_utils/src/pii.rs
@@ -378,7 +378,7 @@ mod pii_masking_strategy_tests {
     /*
     #[test]
     fn test_valid_phone_number_masking() {
-        let secret: Secret<String, PhoneNumber> = Secret::new("9922992299".to_string());
+        let secret: Secret<String, PhoneNumber> = Secret::new("9123456789".to_string());
         assert_eq!("99*****299", format!("{}", secret));
     }
 

diff --git a/crates/common_utils/src/validation.rs b/crates/common_utils/src/validation.rs
@@ -101,7 +101,7 @@ mod tests {
         assert!(validate_phone_number(phone_number).is_ok());
     }
 
-    #[test_case("0745323456" ; "Romanian invalid phone number")]
+    #[test_case("9123456789" ; "Romanian invalid phone number")]
     fn test_invalid_phone_number(phone_number: &str) {
         let res = validate_phone_number(phone_number);
         assert!(res.is_err());

diff --git a/crates/openapi/src/routes/payments.rs b/crates/openapi/src/routes/payments.rs
@@ -35,7 +35,7 @@
                     "customer": {
                       "id": "cus_abcdefgh",
                       "name": "John Dough",
-                      "phone": "9999999999",
+                      "phone": "9123456789",
                       "email": "[email protected]"
                     },
                     "description": "Its my first payment request",
@@ -181,7 +181,7 @@
                         "last_name": "Doe"
                       },
                       "phone": {
-                        "number": "8056594427",
+                        "number": "9123456789",
                         "country_code": "+91"
                       }
                     }
@@ -257,7 +257,7 @@ pub fn payments_retrieve() {}
                     "last_name": "Doe"
                 },
                 "phone": {
-                    "number": "8056594427",
+                    "number": "9123456789",
                     "country_code": "+91"
                 }
               },

diff --git a/crates/router/tests/connectors/aci.rs b/crates/router/tests/connectors/aci.rs
@@ -89,7 +89,7 @@ fn construct_payment_router_data() -> types::PaymentsAuthorizeRouterData {
                     ..Default::default()
                 }),
                 phone: Some(PhoneDetails {
-                    number: Some(Secret::new("8056594427".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+351".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/adyen.rs b/crates/router/tests/connectors/adyen.rs
@@ -66,7 +66,7 @@ impl AdyenTest {
                         last_name: Some(Secret::new("Dough".to_string())),
                     }),
                     phone: Some(PhoneDetails {
-                        number: Some(Secret::new("8056594427".to_string())),
+                        number: Some(Secret::new("9123456789".to_string())),
                         country_code: Some("+351".to_string()),
                     }),
                     email: None,

diff --git a/crates/router/tests/connectors/bitpay.rs b/crates/router/tests/connectors/bitpay.rs
@@ -52,7 +52,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/coinbase.rs b/crates/router/tests/connectors/coinbase.rs
@@ -53,7 +53,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/cryptopay.rs b/crates/router/tests/connectors/cryptopay.rs
@@ -52,7 +52,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/cybersource.rs b/crates/router/tests/connectors/cybersource.rs
@@ -49,7 +49,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,
@@ -202,7 +202,7 @@ async fn should_fail_payment_for_invalid_card_cvc() {
         .make_payment(
             Some(types::PaymentsAuthorizeData {
                 payment_method_data: domain::PaymentMethodData::Card(domain::Card {
-                    card_cvc: Secret::new("2131233213".to_string()),
+                    card_cvc: Secret::new("9123456789".to_string()),
                     ..utils::CCardType::default().0
                 }),
                 ..get_default_payment_authorize_data().unwrap()

diff --git a/crates/router/tests/connectors/forte.rs b/crates/router/tests/connectors/forte.rs
@@ -65,7 +65,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/iatapay.rs b/crates/router/tests/connectors/iatapay.rs
@@ -69,7 +69,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,

diff --git a/crates/router/tests/connectors/nmi.rs b/crates/router/tests/connectors/nmi.rs
@@ -645,7 +645,7 @@ async fn should_fail_capture_for_invalid_payment() {
         .unwrap();
     assert_eq!(sync_response.status, enums::AttemptStatus::Authorized);
     let capture_response = CONNECTOR
-        .capture_payment("7899353591".to_string(), None, None)
+        .capture_payment("9123456789".to_string(), None, None)
         .await
         .unwrap();
     assert_eq!(capture_response.status, enums::AttemptStatus::CaptureFailed);

diff --git a/crates/router/tests/connectors/opennode.rs b/crates/router/tests/connectors/opennode.rs
@@ -52,7 +52,7 @@ fn get_default_payment_info() -> Option<utils::PaymentInfo> {
                     ..Default::default()
                 }),
                 phone: Some(api::PhoneDetails {
-                    number: Some(Secret::new("1234567890".to_string())),
+                    number: Some(Secret::new("9123456789".to_string())),
                     country_code: Some("+91".to_string()),
                 }),
                 email: None,