feat(analytics): remove additional filters from PaymentIntentFilters (#…

…6407)
juspay · Oct 23, 2024 · 838788b · 838788b
1 parent 76dda56
commit 838788b
Show file tree

Hide file tree

Showing 19 changed files with 2 additions and 361 deletions.
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs
@@ -371,15 +371,6 @@ pub async fn get_filters(
             PaymentIntentDimensions::PaymentIntentStatus => fil.status.map(|i| i.as_ref().to_string()),
             PaymentIntentDimensions::Currency => fil.currency.map(|i| i.as_ref().to_string()),
             PaymentIntentDimensions::ProfileId => fil.profile_id,
-            PaymentIntentDimensions::Connector => fil.connector,
-            PaymentIntentDimensions::AuthType => fil.authentication_type.map(|i| i.as_ref().to_string()),
-            PaymentIntentDimensions::PaymentMethod => fil.payment_method,
-            PaymentIntentDimensions::PaymentMethodType => fil.payment_method_type,
-            PaymentIntentDimensions::CardNetwork => fil.card_network,
-            PaymentIntentDimensions::MerchantId => fil.merchant_id,
-            PaymentIntentDimensions::CardLast4 => fil.card_last_4,
-            PaymentIntentDimensions::CardIssuer => fil.card_issuer,
-            PaymentIntentDimensions::ErrorReason => fil.error_reason,
         })
         .collect::<Vec<String>>();
         res.query_data.push(PaymentIntentFilterValue {

diff --git a/crates/analytics/src/payment_intents/filters.rs b/crates/analytics/src/payment_intents/filters.rs
@@ -1,6 +1,6 @@
 use api_models::analytics::{payment_intents::PaymentIntentDimensions, Granularity, TimeRange};
 use common_utils::errors::ReportSwitchExt;
-use diesel_models::enums::{AuthenticationType, Currency, IntentStatus};
+use diesel_models::enums::{Currency, IntentStatus};
 use error_stack::ResultExt;
 use time::PrimitiveDateTime;
 
@@ -54,13 +54,4 @@ pub struct PaymentIntentFilterRow {
     pub status: Option<DBEnumWrapper<IntentStatus>>,
     pub currency: Option<DBEnumWrapper<Currency>>,
     pub profile_id: Option<String>,
-    pub connector: Option<String>,
-    pub authentication_type: Option<DBEnumWrapper<AuthenticationType>>,
-    pub payment_method: Option<String>,
-    pub payment_method_type: Option<String>,
-    pub card_network: Option<String>,
-    pub merchant_id: Option<String>,
-    pub card_last_4: Option<String>,
-    pub card_issuer: Option<String>,
-    pub error_reason: Option<String>,
 }
diff --git a/crates/analytics/src/payment_intents/metrics.rs b/crates/analytics/src/payment_intents/metrics.rs
@@ -34,15 +34,6 @@ pub struct PaymentIntentMetricRow {
     pub status: Option<DBEnumWrapper<storage_enums::IntentStatus>>,
     pub currency: Option<DBEnumWrapper<storage_enums::Currency>>,
     pub profile_id: Option<String>,
-    pub connector: Option<String>,
-    pub authentication_type: Option<DBEnumWrapper<storage_enums::AuthenticationType>>,
-    pub payment_method: Option<String>,
-    pub payment_method_type: Option<String>,
-    pub card_network: Option<String>,
-    pub merchant_id: Option<String>,
-    pub card_last_4: Option<String>,
-    pub card_issuer: Option<String>,
-    pub error_reason: Option<String>,
     pub first_attempt: Option<i64>,
     pub total: Option<bigdecimal::BigDecimal>,
     pub count: Option<i64>,

diff --git a/crates/analytics/src/payment_intents/metrics/payment_intent_count.rs b/crates/analytics/src/payment_intents/metrics/payment_intent_count.rs
@@ -101,15 +101,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/payments_success_rate.rs b/crates/analytics/src/payment_intents/metrics/payments_success_rate.rs
@@ -114,15 +114,6 @@ where
                         None,
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_intent_count.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_intent_count.rs
@@ -101,15 +101,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_processed_amount.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_processed_amount.rs
@@ -128,15 +128,6 @@ where
                         None,
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payments_distribution.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payments_distribution.rs
@@ -113,15 +113,6 @@ where
                         None,
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payments_success_rate.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/payments_success_rate.rs
@@ -114,15 +114,6 @@ where
                         None,
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/smart_retried_amount.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/smart_retried_amount.rs
@@ -122,15 +122,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/successful_smart_retries.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/successful_smart_retries.rs
@@ -111,15 +111,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/sessionized_metrics/total_smart_retries.rs b/crates/analytics/src/payment_intents/metrics/sessionized_metrics/total_smart_retries.rs
@@ -106,15 +106,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/smart_retried_amount.rs b/crates/analytics/src/payment_intents/metrics/smart_retried_amount.rs
@@ -122,15 +122,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/successful_smart_retries.rs b/crates/analytics/src/payment_intents/metrics/successful_smart_retries.rs
@@ -111,15 +111,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/metrics/total_smart_retries.rs b/crates/analytics/src/payment_intents/metrics/total_smart_retries.rs
@@ -106,15 +106,6 @@ where
                         i.status.as_ref().map(|i| i.0),
                         i.currency.as_ref().map(|i| i.0),
                         i.profile_id.clone(),
-                        i.connector.clone(),
-                        i.authentication_type.as_ref().map(|i| i.0),
-                        i.payment_method.clone(),
-                        i.payment_method_type.clone(),
-                        i.card_network.clone(),
-                        i.merchant_id.clone(),
-                        i.card_last_4.clone(),
-                        i.card_issuer.clone(),
-                        i.error_reason.clone(),
                         TimeRange {
                             start_time: match (granularity, i.start_bucket) {
                                 (Some(g), Some(st)) => g.clip_to_start(st)?,

diff --git a/crates/analytics/src/payment_intents/types.rs b/crates/analytics/src/payment_intents/types.rs
@@ -30,63 +30,6 @@ where
                 .add_filter_in_range_clause(PaymentIntentDimensions::ProfileId, &self.profile_id)
                 .attach_printable("Error adding profile id filter")?;
         }
-        if !self.connector.is_empty() {
-            builder
-                .add_filter_in_range_clause(PaymentIntentDimensions::Connector, &self.connector)
-                .attach_printable("Error adding connector filter")?;
-        }
-        if !self.auth_type.is_empty() {
-            builder
-                .add_filter_in_range_clause(PaymentIntentDimensions::AuthType, &self.auth_type)
-                .attach_printable("Error adding auth type filter")?;
-        }
-        if !self.payment_method.is_empty() {
-            builder
-                .add_filter_in_range_clause(
-                    PaymentIntentDimensions::PaymentMethod,
-                    &self.payment_method,
-                )
-                .attach_printable("Error adding payment method filter")?;
-        }
-        if !self.payment_method_type.is_empty() {
-            builder
-                .add_filter_in_range_clause(
-                    PaymentIntentDimensions::PaymentMethodType,
-                    &self.payment_method_type,
-                )
-                .attach_printable("Error adding payment method type filter")?;
-        }
-        if !self.card_network.is_empty() {
-            builder
-                .add_filter_in_range_clause(
-                    PaymentIntentDimensions::CardNetwork,
-                    &self.card_network,
-                )
-                .attach_printable("Error adding card network filter")?;
-        }
-        if !self.merchant_id.is_empty() {
-            builder
-                .add_filter_in_range_clause(PaymentIntentDimensions::MerchantId, &self.merchant_id)
-                .attach_printable("Error adding merchant id filter")?;
-        }
-        if !self.card_last_4.is_empty() {
-            builder
-                .add_filter_in_range_clause(PaymentIntentDimensions::CardLast4, &self.card_last_4)
-                .attach_printable("Error adding card last 4 filter")?;
-        }
-        if !self.card_issuer.is_empty() {
-            builder
-                .add_filter_in_range_clause(PaymentIntentDimensions::CardIssuer, &self.card_issuer)
-                .attach_printable("Error adding card issuer filter")?;
-        }
-        if !self.error_reason.is_empty() {
-            builder
-                .add_filter_in_range_clause(
-                    PaymentIntentDimensions::ErrorReason,
-                    &self.error_reason,
-                )
-                .attach_printable("Error adding error reason filter")?;
-        }
         Ok(())
     }
 }