Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): ignore routing algorithm from merchant account create and business profile create #2253

Closed
wants to merge 27 commits into from

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Sep 21, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • The Json Value routing_algorithm is ignored from the merchant_account_create as well as from the merchant_account_update and same for business-profile_update and create

  • Routing algorithm will now have a default value as algorithm_id =null and timestamp =0 in the Response Body

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested it locally

  • Create a merchant account with the field
  "routing_algorithm": {
        "type": "priority",
        "data": [],
        "timestamp":"{{$timestamp}}"
    },
    

it will get stored with a default algorithm :
Screenshot 2023-10-27 at 2 48 52 PM
MerchantAccountCreate

  • Similarly, for business_profile_create and update as well as merchant_account_update

Screenshot 2023-10-27 at 2 55 44 PMBusinessProfileCreate

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Aprabhat19 Aprabhat19 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Sep 21, 2023
@Aprabhat19 Aprabhat19 requested a review from a team as a code owner September 21, 2023 13:05
@Aprabhat19 Aprabhat19 self-assigned this Sep 21, 2023
@Aprabhat19 Aprabhat19 requested review from a team, jarnura and ashokkjag as code owners September 21, 2023 13:05
@shakthi-22 shakthi-22 added this to the September 2023 Milestone milestone Sep 21, 2023
@Aprabhat19 Aprabhat19 changed the title refactor(core): remove routing algorithm from merchant account create and business profile create refactor(core): ignore routing algorithm from merchant account create and business profile create Oct 27, 2023
@bernard-eugine bernard-eugine removed this from the October 2023 Milestone milestone Nov 6, 2023
@bernard-eugine bernard-eugine added this to the December 2023 Release milestone Dec 5, 2023
@Aprabhat19
Copy link
Contributor Author

Not required

@Aprabhat19 Aprabhat19 closed this Oct 3, 2024
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 6, 2024
@SanchithHegde SanchithHegde deleted the remove-routing-field branch October 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants