-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): ignore routing algorithm
from merchant account create and business profile create
#2253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprabhat19
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
Sep 21, 2023
Aprabhat19
requested review from
a team,
jarnura and
ashokkjag
as code owners
September 21, 2023 13:05
bernard-eugine
modified the milestones:
September 2023 Milestone,
October 2023 Milestone
Oct 10, 2023
…rswitch into remove-routing-field
Aprabhat19
changed the title
refactor(core): remove
refactor(core): ignore Oct 27, 2023
routing algorithm
from merchant account create and business profile createrouting algorithm
from merchant account create and business profile create
Aprabhat19
dismissed stale reviews from Narayanbhat166 and vspecky
via
December 7, 2023 13:10
fc16661
Narayanbhat166
approved these changes
Dec 8, 2023
Not required |
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Json Value
routing_algorithm
is ignored from themerchant_account_create
as well as from themerchant_account_update
and same forbusiness-profile_update
andcreate
Routing algorithm
will now have a default value as algorithm_id =null and timestamp =0 in the Response BodyAdditional Changes
Motivation and Context
How did you test it?
Tested it locally
it will get stored with a default algorithm :
Checklist
cargo +nightly fmt --all
cargo clippy