Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [noon] add validate psync reference #2889

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Nov 16, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add validate_psync_reference_id implementation for Noon as we can make a Psync using connector_request_reference_id and currently core is defaulting if connector_transaction_id is not present it fails the Psync.
Main PR: #2886

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cant be reproduced in envs as either a timeout is required or would need to delete the connector_transaction_id in the DB.

Check for regular proper working of Psyncs in all the cases.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal requested a review from a team as a code owner November 16, 2023 11:12
@SamraatBansal SamraatBansal self-assigned this Nov 16, 2023
@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 16, 2023
@SamraatBansal SamraatBansal changed the title fix(connector): [noon] add validate psync reference (#2886) fix(connector): [noon] add validate psync reference Nov 16, 2023
@SanchithHegde SanchithHegde merged commit 506a05b into hotfix-1.77.0 Nov 16, 2023
16 of 22 checks passed
@SanchithHegde SanchithHegde deleted the fix/noon-psync-call branch November 16, 2023 11:55
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants