Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: amount_captured goes to 0 for 3ds payments #2955

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: amount_captured goes to 0 for 3ds payments #2955

merged 2 commits into from
Nov 23, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Nov 22, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Amount captured would go to 0 for 3ds payments( payments that require redirection ).
Main branch PR: #2954

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual
Screenshot 2023-11-22 at 10 18 55 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 22, 2023
@hrithikesh026 hrithikesh026 added this to the November 2023 Release milestone Nov 22, 2023
@hrithikesh026 hrithikesh026 self-assigned this Nov 22, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners November 22, 2023 16:55
@bernard-eugine bernard-eugine merged commit 5c9e4f5 into hotfix-1.84.0 Nov 23, 2023
12 of 16 checks passed
@bernard-eugine bernard-eugine deleted the amount-capturable-hotfix branch November 23, 2023 07:38
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug
Projects
None yet
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@hrithikesh026 @jarnura @Narayanbhat166 @SanchithHegde @bernard-eugine