Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api_locking): fix the seconds and millis mismatch while fetching configuration #3122

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(api_locking): fix the seconds and millis mismatch while fetching configuration #3122

merged 1 commit into from
Dec 13, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Clones #3121

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 13, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Dec 13, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner December 13, 2023 05:47
@manojradhakrishnan manojradhakrishnan merged commit 0791b41 into hotfix-1.84.0 Dec 13, 2023
7 of 13 checks passed
@manojradhakrishnan manojradhakrishnan deleted the hf/api-locking branch December 13, 2023 06:13
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@knutties knutties knutties approved these changes

@inventvenkat inventvenkat Awaiting requested review from inventvenkat

@dracarys18 dracarys18 Awaiting requested review from dracarys18

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows A-framework Area: Framework C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NishantJoshi00 @knutties @sai-harsha-vardhan @ShankarSinghC @SanchithHegde @manojradhakrishnan