Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users): Added merchant name is list merchants #3294

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

racnan
Copy link
Contributor

@racnan racnan commented Jan 9, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added Merchant name in list merchant api.
PR to main: #3289

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Dashboard needs to show merchant name is available.

How did you test it?

curl --location --request GET '<URL>/user/switch/list' \
--header 'Authorization: Bearer <JWT>'

Above api should return list of merchant accounts the user (whos jwt is being used) has access to.

[
    {
        "merchant_id": "merchant_1704706726",
        "merchant_name": null
    },
    {
        "merchant_id": "merchant_1704706837",
        "merchant_name": "some merchant name"
    }
]

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@racnan racnan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels Jan 9, 2024
@racnan racnan self-assigned this Jan 9, 2024
@racnan racnan requested a review from a team as a code owner January 9, 2024 10:25
@racnan
Copy link
Contributor Author

racnan commented Jan 9, 2024

PR to main: #3289

ThisIsMani
ThisIsMani previously approved these changes Jan 9, 2024
apoorvdixit88
apoorvdixit88 previously approved these changes Jan 9, 2024
…ntInterface` (#3220)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@ThisIsMani ThisIsMani dismissed stale reviews from apoorvdixit88 and themself via c9d2371 January 9, 2024 10:48
@racnan racnan requested a review from a team as a code owner January 9, 2024 10:48
@bernard-eugine bernard-eugine merged commit a4e0c84 into hotfix-1.105.0 Jan 9, 2024
12 of 15 checks passed
@bernard-eugine bernard-eugine deleted the user-list-merchant-name-hf branch January 9, 2024 12:39
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants