Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload #3460

Closed
wants to merge 1 commit into from
Closed

fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload #3460

wants to merge 1 commit into from

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Jan 25, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fix 4xx webhook issue for cashtocode. change amount type from i64 to f64

pr merged in main - #3382

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

test cases -

  1. make a evoucher payment and test webhooks.
Screenshot 2024-01-18 at 2 58 51 PM

issue in prod reproduced in local -
Screenshot 2024-01-18 at 1 41 00 PM

Processing successful webhook
Screenshot 2024-01-18 at 3 05 27 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 requested a review from a team as a code owner January 25, 2024 10:12
@prasunna09 prasunna09 self-assigned this Jan 25, 2024
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 25, 2024
@prasunna09 prasunna09 changed the title fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload Jan 25, 2024
@prasunna09
Copy link
Contributor Author

Closing this pr as this hotfix is not required anymore.

@prasunna09 prasunna09 closed this Jan 26, 2024
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 28, 2024
@SanchithHegde SanchithHegde deleted the fix-cashtocode-webhook branch January 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-c-k akash-c-k akash-c-k approved these changes

@nitesh-balla nitesh-balla nitesh-balla approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@shakthi-22 shakthi-22 Awaiting requested review from shakthi-22

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prasunna09 @ArjunKarthik @nitesh-balla @akash-c-k @SanchithHegde