Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): make payment_instrument optional #4390

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix(router): make payment_instrument optional #4390

merged 2 commits into from
Apr 18, 2024

Conversation

AkshayaFoiger
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger commented Apr 17, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix simplified Applepay deserialization error
Hotfix for #4389

Test Case

1.Applepay non mandate simplified payment

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested review from a team as code owners April 17, 2024 14:39
@AkshayaFoiger AkshayaFoiger changed the base branch from main to hotfix-2024.04.12.1 April 17, 2024 14:45
@AkshayaFoiger AkshayaFoiger changed the title fix(router): make payment_instrument optional fix(connector): [BOA/CYBS] make payment_instrument optional Apr 17, 2024
@AkshayaFoiger AkshayaFoiger self-assigned this Apr 17, 2024
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration C-bug Category: Bug labels Apr 17, 2024
@AkshayaFoiger AkshayaFoiger changed the title fix(connector): [BOA/CYBS] make payment_instrument optional fix(router): make payment_instrument optional Apr 17, 2024
@AkshayaFoiger AkshayaFoiger changed the title fix(router): make payment_instrument optional fix(router): make payment_instrument optional Apr 17, 2024
@AkshayaFoiger AkshayaFoiger changed the title fix(router): make payment_instrument optional fix(router): make payment_instrument optional Apr 17, 2024
@likhinbopanna likhinbopanna merged commit adfe0a4 into hotfix-2024.04.12.1 Apr 18, 2024
11 of 13 checks passed
@likhinbopanna likhinbopanna deleted the hot-fix-boa branch April 18, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AkshayaFoiger @ArjunKarthik @SamraatBansal @sai-harsha-vardhan @likhinbopanna