chore(deps): change precision point of time #4453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-97
changed the title
dracarys18
previously approved these changes
Apr 24, 2024
Narayanbhat166
previously approved these changes
Apr 24, 2024
hyperswitch-bot
bot
dismissed stale reviews from Narayanbhat166 and dracarys18
via
ed7cbd5
dracarys18
approved these changes
Apr 24, 2024
Narayanbhat166
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
round off for ms when precision set to 3 is generating faulty seconds value of 60, having a larger precision so that rounding off doesnt happen (permanent fix is to update time crate once issue is resolved)
hotfix pr: #4401
Additional Changes
Motivation and Context
round off for ms when precision set to 3 is generating faulty seconds value of 60, having a larger precision so that rounding off doesnt happen (permanent fix is to update time crate once issue is resolved)
How did you test it?
run unit tests by generating timestamps, no specific integration tests
Checklist
cargo +nightly fmt --allcargo clippy