feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

swangi-kumari · 2024-05-08T13:49:27Z

Type of Change

Description

Implement Payments and PSync flows for Mifinity connector.
Implement Mifinity Payment Method.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create a Merchant

{
  "merchant_id": "merchant_{{$timestamp}}",
  "locker_id": "m0010",
  "merchant_name": "NewAge Retailer",
  "merchant_details": {
    "primary_contact_person": "John Test",
    "primary_email": "[email protected]",
    "primary_phone": "sunt laborum",
    "secondary_contact_person": "John Test2",
    "secondary_email": "[email protected]",
    "secondary_phone": "cillum do dolor id",
    "website": "https://www.example.com",
    "about_business": "Online Retail with a wide selection of organic products for North America",
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US"
    }
  },
  "return_url": "https://google.com/success",
  "webhook_details": {
    "webhook_version": "1.0.1",
    "webhook_username": "ekart_retail",
    "webhook_password": "password_ekart@123",
    "payment_created_enabled": true,
    "payment_succeeded_enabled": true,
    "payment_failed_enabled": true
  },
  "sub_merchants_enabled": false,
  "metadata": {
    "city": "NY",
    "unit": "245"
  },
  "primary_business_details": [
    {
      "country": "US",
      "business": "food"
    }
  ]
}

Create API Key

{
  "name": "API Key 1",
  "description": null,
  "expiration": "2038-01-19T03:14:08.000Z"
}

Payment Connector Create

{
    "connector_type": "fiz_operations",
    "connector_name": "mifinity",
    "connector_account_details": {
        "auth_type": "HeaderKey",
        "api_key": "{______}"
    },
    "test_mode": false,
    "disabled": false,
    "payment_methods_enabled": [
                 {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "mifinity",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245",
        "brand_id": "001"
    },
    "business_country": "US",
    "business_label": "food"
}

Create a Mifinity Wallet Payment via Mifinity

    "amount": 1000,
    "currency": "EUR",
    "confirm": true,
      "capture_method": "automatic",
      "capture_on": "2022-09-10T10:11:12Z",
      "amount_to_capture": 1000,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
      "authentication_type": "no_three_ds",
    "return_url": "https://www.google.com/",
    "payment_method": "wallet",
    "payment_method_type": "mifinity",
    "payment_method_data": {
        "wallet": {
            "mifinity": {
                "destination_account_number": "5001000001223369",
                "dob": "2001-10-16"
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
    // "business_label": "food", 
    // "business_country": "US",
    // "profile_id": "pro_vsFxMOhOqXt4FMYjVral"
}

Response

Using redirection_url in response complete the payment

{
    "payment_id": "pay_QoGz4Pu98CFsMxtT5HWZ",
    "merchant_id": "merchant_1716269219",
    "status": "requires_customer_action",
    "amount": 1000,
    "net_amount": 1000,
    "amount_capturable": 1000,
    "amount_received": null,
    "connector": "mifinity",
    "client_secret": "pay_QoGz4Pu98CFsMxtT5HWZ_secret_2cbvKwEt2LffCDYhFIgQ",
    "created": "2024-05-21T05:43:12.607Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "[email protected]",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "wallet",
    "payment_method_data": {
        "wallet": {},
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "order_details": null,
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_QoGz4Pu98CFsMxtT5HWZ/merchant_1716269219/pay_QoGz4Pu98CFsMxtT5HWZ_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "mifinity",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer",
        "created_at": 1716270192,
        "expires": 1716273792,
        "secret": "epk_91cebf4aba1241c0be573e5bd807b070"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "payment_link": null,
    "profile_id": "pro_HqWDRNDr8bL3Wi7Z5wIN",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_RkJnWGLzO9fDEYXEP1cb",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-21T05:58:12.607Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-21T05:43:13.983Z",
    "frm_metadata": null
}

do a PSync with same payment_id

Response

{
    "payment_id": "pay_QoGz4Pu98CFsMxtT5HWZ",
    "merchant_id": "merchant_1716269219",
    "status": "succeeded",
    "amount": 1000,
    "net_amount": 1000,
    "amount_capturable": 0,
    "amount_received": 1000,
    "connector": "mifinity",
    "client_secret": "pay_QoGz4Pu98CFsMxtT5HWZ_secret_2cbvKwEt2LffCDYhFIgQ",
    "created": "2024-05-21T05:43:12.607Z",
    "currency": "EUR",
    "customer_id": "StripeCustomer",
    "customer": {
        "id": "StripeCustomer",
        "name": "John Doe",
        "email": "[email protected]",
        "phone": "999999999",
        "phone_country_code": "+1"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "wallet",
    "payment_method_data": {
        "wallet": {},
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "DE",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "order_details": null,
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "return_url": "https://www.google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "mifinity",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "aea08e48-68cb-44f3-8fca-c3c5c659700c",
    "frm_message": null,
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pay_QoGz4Pu98CFsMxtT5HWZ_1",
    "payment_link": null,
    "profile_id": "pro_HqWDRNDr8bL3Wi7Z5wIN",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_RkJnWGLzO9fDEYXEP1cb",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-05-21T05:58:12.607Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-05-21T05:47:52.254Z",
    "frm_metadata": null
}

Create a payment with "capture_method": "manual",

{
    "amount": 1000,
    "currency": "EUR",
    "confirm": true,
    "capture_method": "manual",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 1000,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://www.google.com/",
    "payment_method": "wallet",
    "payment_method_type": "mifinity",
    "payment_method_data": {
        "wallet": {
            "mifinity": {
                "destination_account_number": "5001000001223369",
                "date_of_birth": "2001-10-16"
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": "[email protected]"
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "DE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}

Response

{
    "error": {
        "type": "invalid_request",
        "message": "Payment method type not supported",
        "code": "HE_03",
        "reason": "manual is not supported by mifinity"
    }
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…into mifinity-impl

SamraatBansal · 2024-06-03T07:53:46Z

crates/router/src/connector/mifinity/transformers.rs

+
+#[derive(Debug, Default, Serialize, Deserialize)]
+pub struct MifinityConnectorMetadataObject {
+    pub brand_id: String,


Suggested change

pub brand_id: String,

pub brand_id: Secret<String>,

crates/router/src/connector/mifinity/transformers.rs

SanchithHegde · 2024-06-05T14:19:01Z

crates/router/src/connector/mifinity/transformers.rs

+pub struct MifinityAddress {
+    address_line1: Secret<String>,
+    country_code: api_models::enums::CountryAlpha2,
+    city: String,


@SamraatBansal Should we consider making this a Secret<String>?

City and Country are not sensitive info according to pii guidelines.
Core also does not consider it as secret so same is translated here

crates/router/src/connector/mifinity/transformers.rs

…out-fix * 'main' of github.com:juspay/hyperswitch: refactor(connector): convert init payment flow to preprocessing flow for shift4 (#4884) ci(cypress): Add billing address for bank redirects (#4903) refactor(openapi): move openapi to a separate folder (#4859) chore(version): 2024.06.07.0 refactor(outgoing_webhooks): raise errors in the analytics pipeline in case of API client errors or non-2xx responses (#4894) chore(config): [MIFINITY] add configs for Mifinity in WASM (#4895) feat(router): add `acquirer_country_code` in acquirer_details and send it in netcetera authentication flow (#4835) refactor(connector): convert init payment flow to preprocessing flow for nuvei (#4878) feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method (#4592) fix(connectors): [BOA/CYBS] make avs code optional (#4898) feat(events): add metadata info to events (#4875)

swangi-kumari and others added 8 commits April 24, 2024 11:42

refactor: add template code for mifinity

c492f98

docs(openapi): re-generate OpenAPI specification

c7a161b

Merge branch 'main' into mifinity-template-code

1b75cee

refactor: fix

90c4bd8

docs(openapi): re-generate OpenAPI specification

21b4c61

Merge branch 'main' into mifinity-template-code

9712441

feat: implement mifinity

87ba8dd

Merge branch 'main' into mifinity-impl

8ffb2a4

swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels May 8, 2024

swangi-kumari self-assigned this May 8, 2024

swangi-kumari and others added 15 commits May 9, 2024 12:12

Merge branch 'main' into mifinity-impl

6cccbf2

refactor: payments

54a5703

Merge branch 'main' into mifinity-impl

120320a

feat: payments and sync

5631bac

refactor: transaction_reference in psync

6d5004f

chore: run formatter

61544a9

refactor: add brand_id for mifinity in metadata

bc9924e

Merge branch 'mifinity-impl' of https://github.com/juspay/hyperswitch …

78fdc58

…into mifinity-impl

refactor: solve clippy

4abddb7

Merge branch 'main' into mifinity-impl

d547e85

refactor: clippy

8690792

refactor: add dependency to support Date

e746994

time dependency added

9b2f176

chore: run formatter

c4b75c5

transfermer status update

e3eab66

KiranKBR force-pushed the mifinity-impl branch from c4b75c5 to e3eab66 Compare May 20, 2024 15:21

swangi-kumari and others added 3 commits May 20, 2024 21:46

Merge branch 'mifinity-impl' of https://github.com/juspay/hyperswitch …

b597beb

…into mifinity-impl

refactor: resolve clippy

e3e502b

feature enabled serde-human-readable

4cc284d

SamraatBansal requested changes Jun 3, 2024

View reviewed changes

refactor: make brand id secrte in meta data

e8d7fb3

srujanchikke previously approved these changes Jun 5, 2024

View reviewed changes

SamraatBansal previously approved these changes Jun 5, 2024

View reviewed changes

SanchithHegde reviewed Jun 5, 2024

View reviewed changes

refactor: resolve cnflicts

277f481

swangi-kumari dismissed stale reviews from SamraatBansal and srujanchikke via 277f481 June 5, 2024 15:51

SamraatBansal previously approved these changes Jun 5, 2024

View reviewed changes

SanchithHegde previously approved these changes Jun 5, 2024

View reviewed changes

srujanchikke previously approved these changes Jun 6, 2024

View reviewed changes

ShankarSinghC previously approved these changes Jun 6, 2024

View reviewed changes

Gnanasundari24 enabled auto-merge June 6, 2024 10:59

Gnanasundari24 disabled auto-merge June 6, 2024 11:00

refactor: resolve conflicts

0fe7493

swangi-kumari dismissed stale reviews from ShankarSinghC, srujanchikke, SanchithHegde, and SamraatBansal via 0fe7493 June 6, 2024 11:09

srujanchikke approved these changes Jun 6, 2024

View reviewed changes

SamraatBansal approved these changes Jun 6, 2024

View reviewed changes

ShankarSinghC approved these changes Jun 6, 2024

View reviewed changes

SanchithHegde approved these changes Jun 6, 2024

View reviewed changes

Gnanasundari24 enabled auto-merge June 6, 2024 11:54

Gnanasundari24 added this pull request to the merge queue Jun 6, 2024

Merged via the queue into main with commit 6750be5 Jun 6, 2024
10 checks passed

Gnanasundari24 deleted the mifinity-impl branch June 6, 2024 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

swangi-kumari commented May 8, 2024 •

edited

Loading

SamraatBansal Jun 3, 2024

SanchithHegde Jun 5, 2024

SamraatBansal Jun 5, 2024

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

feat(connector): [MIFINITY] Implement payment flows and Mifinity payment method #4592

Conversation

swangi-kumari commented May 8, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

SamraatBansal Jun 3, 2024

Choose a reason for hiding this comment

SanchithHegde Jun 5, 2024

Choose a reason for hiding this comment

SamraatBansal Jun 5, 2024

Choose a reason for hiding this comment

swangi-kumari commented May 8, 2024 •

edited

Loading