refactor(analytics): Adds tenant ID to Analytics Provider #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added tenant_id param to from_conf method. Is that the correct way? @lsampras |
lsampras
reviewed
May 9, 2024
crates/analytics/src/lib.rs
Outdated
Comment on lines
67
to
68
| #[derive(Clone, Debug)] | ||
| pub struct TenantID(String); |
There was a problem hiding this comment.
Can you move this struct definition to the common_utils crate?
There was a problem hiding this comment.
I moved it to types.rs in common_utils crate and added #[allow(unused)] in some places so clippy can stop complaining. Is that fine?
lsampras
previously approved these changes
May 13, 2024
|
@RaghavRox the latest commit fails to compile due to some errors, |
lsampras
previously approved these changes
May 27, 2024
lsampras
previously approved these changes
May 30, 2024
ShivanshMathurJuspay
previously approved these changes
May 31, 2024
lsampras
previously approved these changes
May 31, 2024
ivor11
previously approved these changes
May 31, 2024
lsampras
dismissed stale reviews from ivor11, ShivanshMathurJuspay, and themself
via
f30b4a1
ShivanshMathurJuspay
previously approved these changes
May 31, 2024
ivor11
previously approved these changes
May 31, 2024
prajjwalkumar17
previously approved these changes
May 31, 2024
lsampras
previously approved these changes
May 31, 2024
lsampras
dismissed stale reviews from prajjwalkumar17, ivor11, and themself
via
cbc9ec4
|
the changes here are covered in #4867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4521
Type of Change
Description
Adds TenantID field to SqlxClient and ClickHouseClient
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy