-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payment_charges): add support for collecting and refunding charges on payments #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(charges): add charges integration for Stripe
…t in payment's response
kashif-m
changed the title
Payment charges
feat(payment_charges): add support for collecting and refunding charges on payments
May 15, 2024
2 tasks
kashif-m
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
M-database-changes
Metadata: This PR involves database schema changes
M-api-contract-changes
Metadata: This PR involves API contract changes
A-refunds
Area: Refund flows
A-payments
Area: payments
and removed
A-core
Area: Core flows
labels
May 15, 2024
SamraatBansal
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approving on behalf of connectors
SamraatBansal
previously approved these changes
May 22, 2024
Narayanbhat166
previously approved these changes
May 22, 2024
SamraatBansal
previously approved these changes
May 23, 2024
ThisIsMani
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes looks fine.
kashif-m
dismissed stale reviews from ThisIsMani, SamraatBansal, and Narayanbhat166
via
May 23, 2024 10:56
c78ebf1
SamraatBansal
approved these changes
May 23, 2024
Narayanbhat166
approved these changes
May 24, 2024
ThisIsMani
approved these changes
May 24, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
May 26, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payments
Area: payments
A-refunds
Area: Refund flows
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Detailed description - #4659
This PR adds functionality to create charges on payment intents using Stripe
charges
on payment_intentcharge_id
in payment_attemptcharge_id
for refundsNote - charges on mandates is not added in this PR.
Additional Changes
Motivation and Context
How did you test it?
Tested locally using postman collection.
Steps for testing
/payment_intents
request/payment_intents
requestDirect charges
Destination charges
Checklist
cargo +nightly fmt --all
cargo clippy