chore: move RouterData Request types to hyperswitch_domain_models crate #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-refactor
jarnura
previously approved these changes
May 22, 2024
crates/hyperswitch_domain_models/src/errors/api_error_response.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_domain_models/src/errors/api_error_response.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remove this file and the mod declaration here:
| } | ||
| } | ||
| } | ||
| pub use hyperswitch_domain_models::payment_method_data::*; |
There was a problem hiding this comment.
If it isn't asking for too much, can we avoid the wildcard import here?
SanchithHegde
approved these changes
May 23, 2024
jarnura
approved these changes
May 23, 2024
likhinbopanna
deleted the
move-router-data-request-models-to-hyperswitch-domain-models
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Moved RouterData::Request types to hyperswitch domain models crate.
Other changes:
Moved
enum ApiErrorResponsetohyperswitch domain modelsas wellAdditional Changes
Motivation and Context
How did you test it?
Checked if the code compiles successfully.
Checklist
cargo +nightly fmt --allcargo clippy