Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add payment method collect links #4738

Closed
wants to merge 23 commits into from
Closed

feat: add payment method collect links #4738

wants to merge 23 commits into from

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented May 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds a base for creating and serving generic links. This also adds creation and rendering of payment method collect links using the generic link base.

PR 2 - #4941
PR 3 - #4967

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Treating links as a generic entity helps put similar workflows in the same place (collect + payout + payment links) and also enforces the same practices among different types of links creating a unified structure and process for these links.

How did you test it?

Tested locally using SDK and postman collection.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this May 23, 2024
@kashif-m kashif-m linked an issue Jun 11, 2024 that may be closed by this pull request
2 tasks
@hyperswitch-bot hyperswitch-bot bot added M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jun 11, 2024
@kashif-m kashif-m marked this pull request as ready for review June 24, 2024 08:27
@kashif-m kashif-m requested review from a team as code owners June 24, 2024 08:27
@kashif-m kashif-m requested review from a team as code owners June 24, 2024 08:27
Copy link
Contributor

@racnan racnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from dashboard side

Copy link
Contributor

@sahkal sahkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility changes LGTM!

@kashif-m kashif-m closed this Jun 25, 2024
@kashif-m
Copy link
Contributor Author

Included in this - #4967

@SanchithHegde SanchithHegde deleted the pm_collect_link branch June 30, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add links for collecting payout method details
4 participants