-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add payment method collect links #4738
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms + DB queries + transformers add create collect link flow - validate and initiate flow
refactor(diesel_models/generic_link): add distinct queries as per link_type refactor(collect_link): hide sensitive data feat(collect_link): inject dynamic content in collect link and it's status page
2 tasks
hyperswitch-bot
bot
added
M-database-changes
Metadata: This PR involves database schema changes
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Jun 11, 2024
racnan
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from dashboard side
sahkal
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility changes LGTM!
lsampras
approved these changes
Jun 25, 2024
Included in this - #4967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds a base for creating and serving generic links. This also adds creation and rendering of payment method collect links using the generic link base.
PR 2 - #4941
PR 3 - #4967
Additional Changes
Motivation and Context
Treating links as a generic entity helps put similar workflows in the same place (collect + payout + payment links) and also enforces the same practices among different types of links creating a unified structure and process for these links.
How did you test it?
Tested locally using SDK and postman collection.
Checklist
cargo +nightly fmt --all
cargo clippy