Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix unit tests for routing #4743

Merged
merged 1 commit into from
May 23, 2024
Merged

ci: fix unit tests for routing #4743

merged 1 commit into from
May 23, 2024

Conversation

vspecky
Copy link
Member

@vspecky vspecky commented May 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes a couple of failing unit tests in the euclid and kgraph_utils crates.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Running unit tests locally. API Tests not required

image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@vspecky vspecky added A-CI-CD Area: Continuous Integration/Deployment C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-euclid-foc Area: Euclid Family of Crates A-constraint-graph Area: Constraint Graph labels May 23, 2024
@vspecky vspecky added this to the May 2024 Release milestone May 23, 2024
@vspecky vspecky self-assigned this May 23, 2024
@vspecky vspecky requested a review from a team as a code owner May 23, 2024 08:01
@vspecky vspecky linked an issue May 23, 2024 that may be closed by this pull request
[BUG] Failing unit tests for routing and constraint graph #4742
Closed
2 tasks
@vspecky vspecky changed the title ci: fix tests for routing ci: fix unit tests for routing May 23, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit ee276ec May 23, 2024
16 checks passed
@likhinbopanna likhinbopanna deleted the fix-routing-tests branch May 23, 2024 09:28
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aprabhat19 Aprabhat19 Aprabhat19 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@vspecky vspecky

Labels
A-CI-CD Area: Continuous Integration/Deployment A-constraint-graph Area: Constraint Graph A-euclid-foc Area: Euclid Family of Crates C-bug Category: Bug
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.

[BUG] Failing unit tests for routing and constraint graph
4 participants
@vspecky @SanchithHegde @Aprabhat19 @likhinbopanna