Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netcetera): handle non-ascii characters for cardholdername, error message and send missing fields #4755

Merged
merged 3 commits into from
May 30, 2024
Merged

fix(netcetera): handle non-ascii characters for cardholdername, error message and send missing fields #4755

merged 3 commits into from
May 30, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented May 23, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. handle non-ascii characters for cardholdername, convert into ascii equivalent and then send to netcetera
  2. send message and reason in error_message
  3. remove unnecessary fields and send required fields

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Sanity external 3ds payments (friction and frictionless) through netcetera

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 23, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the May 2024 Release milestone May 23, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this May 23, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners May 23, 2024 14:31
hrithikesh026
hrithikesh026 previously approved these changes May 30, 2024
View reviewed changes
@preetamrevankar preetamrevankar added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 5d1900e May 30, 2024
13 checks passed
@preetamrevankar preetamrevankar deleted the fix-issues-3ds-netcetera branch May 30, 2024 15:12
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@hrithikesh026 hrithikesh026 hrithikesh026 approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@sai-harsha-vardhan @Narayanbhat166 @hrithikesh026 @srujanchikke @SanchithHegde @preetamrevankar