Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multitenancy): move users and tenants to global schema #4781

Merged
merged 68 commits into from
Jun 5, 2024
Merged

feat(multitenancy): move users and tenants to global schema #4781

merged 68 commits into from
Jun 5, 2024

Conversation

jagan-jaya
Copy link
Contributor

@jagan-jaya jagan-jaya commented May 27, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Users will be global and not tied to a tenant
Login page will be one and not customized. An option to switch tenants will be provided

https://github.com/juspay/hyperswitch-product/issues/50

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To establish tenancy in our application and start using the default tenant as 'Hyperswitch' and also offer a 'test' tenant in all environments

Users will be global and not tied to a tenant
Login page will be one and not customized. An option to switch tenants will be provided

How did you test it?

  1. Start router and control center and try creating new user account.
  2. Check if the user is getting created and an entry added in public schema for the user
  3. Try sign out from the control center and login again
  4. Login should work as expected

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

jagan-jaya and others added 30 commits April 30, 2024 12:44
@jagan-jaya
feat(multitenancy): add logical sepration of tenant using db schema
85e3676
@jagan-jaya
feat(multitenancy): add base_url for redirection and pay start
2265882
@jagan-jaya
feat(multitenancy): format code and remove unused deps
50559b7
@jagan-jaya
feat(multitenancy): create sessionstate for scheduler
54c1aee
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
f6d3dac 
…titenancy
@hyperswitch-bot
chore: run formatter
7d35c89
@jagan-jaya
feat(multitenancy): update tenants
b2b05c3
@jagan-jaya
Merge branch 'multitenancy' of https://github.com/juspay/hyperswitch …
4a5748c 
…into multitenancy
@jagan-jaya
feat(multitenancy): fix clippy warnings
e60f9b5
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
c1602da 
…titenancy
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
978fbe4 
…titenancy-users
@jagan-jaya
feat(multitenancy): fix clippy warnings
d707357
@jagan-jaya
feat(multitenancy): fix clippy warnings
c9405db
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
dda08c8 
…titenancy
@hyperswitch-bot
chore: run formatter
c376ffc
@jagan-jaya
feat(multitenancy): add support to enable/disable multitenancy support
c78729e
@jagan-jaya
Merge branch 'multitenancy' of https://github.com/juspay/hyperswitch …
66d8d4d 
…into multitenancy
@jagan-jaya
fix: clear redis entry on update operation
f103acc
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
b3609b8 
…titenancy
@hyperswitch-bot
chore: run formatter
4e941d6
@jagan-jaya
feat: add tenant support in in-memory cache
f852184
@jagan-jaya
Merge branch 'multitenancy' of https://github.com/juspay/hyperswitch …
9e27425 
…into multitenancy
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
6a174a2 
…titenancy
@jagan-jaya
feat: add tenant support in in-memory cache
e0cb6f0
@jagan-jaya
feat: address PR comments
a6d1936
@jagan-jaya
feat: address PR comments
69f5fb4
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
18a75c0 
…titenancy
@jagan-jaya
Merge branch 'main' of https://github.com/juspay/hyperswitch into mul…
983068d 
…titenancy-users
@jagan-jaya
feat: add global tenant for users
d740d78
@jagan-jaya
Merge branch 'multitenancy-users' of https://github.com/juspay/hypers…
2a4bb9b 
…witch into multitenancy-users
Base automatically changed from multitenancy to main June 3, 2024 12:43
@jagan-jaya jagan-jaya changed the title Multitenancy users feat(multitenancy): move users and tenants to global schema Jun 4, 2024
@jagan-jaya jagan-jaya marked this pull request as ready for review June 4, 2024 11:37
@jagan-jaya jagan-jaya requested review from a team as code owners June 4, 2024 11:37
@jagan-jaya jagan-jaya self-assigned this Jun 4, 2024
@jagan-jaya jagan-jaya requested a review from racnan June 4, 2024 11:38
@jagan-jaya jagan-jaya added A-core Area: Core flows A-users Area: Users labels Jun 4, 2024
@jagan-jaya jagan-jaya requested a review from jarnura June 4, 2024 11:44
jarnura
jarnura previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

racnan
racnan reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@racnan racnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the join query if it wont be used and wont work if used.

@jarnura jarnura enabled auto-merge June 5, 2024 13:00
lsampras
lsampras approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@lsampras lsampras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the analytics/reporting changes look good

racnan
racnan approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@racnan racnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join query not removed.

@jarnura jarnura added this pull request to the merge queue Jun 5, 2024
@jagan-jaya
Copy link
Contributor Author

jagan-jaya commented Jun 5, 2024 •
edited
Loading

#4781 (review)
Will be fixed in this PR

Merged via the queue into main with commit c5e28f2 Jun 5, 2024
10 checks passed
@jarnura jarnura deleted the multitenancy-users branch June 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racnan racnan racnan approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@jagan-jaya jagan-jaya

Labels
A-core Area: Core flows A-users Area: Users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jagan-jaya @jarnura @lsampras @racnan