-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(payment_methods): filter the apple pay retryable connectors for a specific business profile with default fallback configuration #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specific business profile
…le_pay/fix-auto-retry
…le_pay/fix-auto-retry
sai-harsha-vardhan
approved these changes
Jun 9, 2024
Chethan-rao
reviewed
Jun 9, 2024
@@ -4031,7 +4037,33 @@ where | |||
} | |||
} | |||
} | |||
Some(connector_data_list) | |||
|
|||
let fallback_connetors_list = crate::core::routing::helpers::get_merchant_default_config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Suggested change
let fallback_connetors_list = crate::core::routing::helpers::get_merchant_default_config( | |
let fallback_connectors_list = crate::core::routing::helpers::get_merchant_default_config( |
Not a blocker
Chethan-rao
approved these changes
Jun 9, 2024
ShankarSinghC
added a commit
that referenced
this pull request
Jun 14, 2024
… specific business profile with default fallback configuration (#4794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently while fetching the apple pay retry connector list all the enabled merchant connector accounts for that specific merchant id is included. But we need to retry the connector with only the connectors in that specific profile id with which the payment attempt was created. Also range the apple pay retry connector in the default fallback configuration sequence.
Additional Changes
Motivation and Context
How did you test it?
-> Create merchant connector accounts with apple pay simplified configured for some of them.
-> Use the below curl to set the default connectors
-> Create a payment with confirm false
-> Do payment method list for the merchant
-> Confirm the payment with apple pay payment data
Checklist
cargo +nightly fmt --all
cargo clippy