fix(cypress): fix redirectionHandler from failing to compile
#4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
changed the title
redirectionHandler from failing to compile
likhinbopanna
previously approved these changes
Jun 3, 2024
SanchithHegde
previously approved these changes
Jun 3, 2024
Comment on lines
238
to
243
| cy.get(".BankSearch_searchInput__uX_9l").type( | ||
| "Volksbank Hildesheim{enter}" | ||
| ); | ||
| cy.get(".BankSearch_searchIcon__EcVO7").click(); | ||
| cy.get(".BankSearch_bankWrapper__R5fUK").click(); | ||
| cy.get("._transactionId__primaryButton__nCa0r").click(); |
There was a problem hiding this comment.
Won't these identifiers change over time?
There was a problem hiding this comment.
I believe not. Other simpler methods never worked here when I tried. Had to resort to the work that @tsdk02 and @Abhitator216 had done.
pixincreate
dismissed stale reviews from SanchithHegde and likhinbopanna
via
8d3deea
SanchithHegde
previously approved these changes
Jun 3, 2024
Sakilmostak
previously approved these changes
Jun 4, 2024
SanchithHegde
previously approved these changes
Jun 4, 2024
* 'main' of github.com:juspay/hyperswitch: feat(cypress): Add service level testing for Payouts (#4744) feat(auth): Create and use `SinglePurposeOrLoginTokenAuth` (#4830) refactor(connector): [Adyen] handle redirection error response (#4862) refactor(api_models): rename Card struct for payouts to avoid overrides in auto generated open API spec (#4861) chore(version): 2024.06.04.1 fix(connector): [Adyen]add required fields for afterpay clearpay (#4858) chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798)
pixincreate
dismissed stale reviews from SanchithHegde and Sakilmostak
via
7a6e897
SanchithHegde
approved these changes
Jun 4, 2024
Sakilmostak
approved these changes
Jun 4, 2024
pixincreate
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
It looks like Jenkins expects file names to be case sensitive which is good. However, that led to Cypress tests to fail.
In
commands.js, we've given the file name to be./redirectionHandlerto be imported while the actual file name is./redirectionhandler.Execute:
Had to add a normaliser function as on Jenkins, it considers a standard connector name:
Additional Changes
Motivation and Context
NIL
How did you test it?
CI should not cry from now on. But on local, this bug is not reproducible.
Checklist
cargo +nightly fmt --allcargo clippy