refactor(router): changed payment method token TTL to api contract based config from const value #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed config from const value (#5115) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
sahkal
added
A-core
hyperswitch-bot
bot
added
the
M-api-contract-changes
sahkal
changed the title
jarnura
approved these changes
Jul 4, 2024
sahkal
changed the title
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently the payment method token TLL calculation was done based on const::TOKEN_TTL - payment_intent.created_at
where TOKEN_TTL was 15mins, but as we have a new contract called session_expiry we can make our payment live for longer time constraint than just 15mins,
due to this, the value const::TOKEN_TTL - payment_intent.created_at might go negative if the payment is done after 15mins. Which causes negative value at redis.
To solve, This problem we have used intent_fulfillment_time in business profile which is set by the merchant.
max value of intent_fulfillment_time can be 30mins and min can be 1min
Please refer PR: #5115
Checklist
cargo +nightly fmt --allcargo clippy