Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment-config): remove invalid currencies from worldpay filters #6422

Closed
wants to merge 1 commit into from

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Oct 24, 2024

(cherry picked from commit aee11c5)

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Hotfix PR for #6400

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Using ENV from sandbox.toml in development.toml for local runs.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Oct 24, 2024
@kashif-m kashif-m requested a review from a team as a code owner October 24, 2024 08:36
Copy link

Review changes with SemanticDiff.

@kashif-m kashif-m changed the title fix(deployment-config): remove invalid currencies from worldpay filte… fix(deployment-config): remove invalid currencies from worldpay filters Oct 24, 2024
@kashif-m kashif-m linked an issue Oct 24, 2024 that may be closed by this pull request
2 tasks
@kashif-m kashif-m changed the title fix(deployment-config): remove invalid currencies from worldpay filters fix(deployment-config): remove invalid currencies from worldpay filters (#6400) Oct 24, 2024
@kashif-m kashif-m changed the title fix(deployment-config): remove invalid currencies from worldpay filters (#6400) fix(deployment-config): remove invalid currencies from worldpay filters Oct 24, 2024
@kashif-m kashif-m closed this Oct 24, 2024
@SanchithHegde SanchithHegde deleted the fix-deployment-config-hotfix branch October 27, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Worldpay payments integration
2 participants