Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): get apple pay certificates only from metadata during the session call #6515

Closed
wants to merge 3 commits into from
Closed

fix(router): get apple pay certificates only from metadata during the session call #6515

wants to merge 3 commits into from

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ShankarSinghC ShankarSinghC requested a review from a team as a code owner November 8, 2024 08:14
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 8, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments/flows/session_flow.rs  29% smaller
  CHANGELOG.md Unsupported file format
  crates/router/src/core/payments/operations/payment_create.rs  0% smaller
  crates/router/src/events/audit_events.rs  0% smaller

@ShankarSinghC ShankarSinghC self-assigned this Nov 8, 2024
@ShankarSinghC ShankarSinghC added A-core Area: Core flows C-bug Category: Bug A-payment-methods Area: Payment Methods A-payments Area: payments labels Nov 8, 2024
@ShankarSinghC ShankarSinghC changed the base branch from main to hotfix-2024.11.07.1 November 8, 2024 08:20
@ShankarSinghC ShankarSinghC requested review from a team as code owners November 8, 2024 08:20
@ShankarSinghC
Copy link
Contributor Author

Closing this pr as this changes are included in #6517

@SanchithHegde SanchithHegde deleted the apple_pay/hotfix-session-call branch November 10, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods A-payments Area: payments C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShankarSinghC @Rutam21