refactor(address): change address to domain address in application #6608
+412
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle JSON serialization and encryption
hyperswitch-bot
bot
added
the
M-api-contract-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
A new type has been added to the domain models called
Address. This type has been used in the application everywhere where we use address.Motivation and Context
How did you test it?
{ "id": "12345_pay_01936eb3d8f27892b0fc10f02351516c", "status": "requires_payment_method", "amount_details": { "order_amount": 100, "currency": "USD", "shipping_cost": null, "order_tax_amount": null, "external_tax_calculation": "skip", "surcharge_calculation": "skip", "surcharge_amount": null, "tax_on_surcharge": null }, "client_secret": "12345_pay_01936eb3d8f27892b0fc10f02351516c_secret_01936eb3d8f379e3ab40edeedf17445d", "profile_id": "pro_U0hvw0D9plClPdsoS1Gj", "merchant_reference_id": null, "routing_algorithm_id": null, "capture_method": "automatic", "authentication_type": "no_three_ds", "billing": { "address": { "city": null, "country": null, "line1": null, "line2": null, "line3": null, "zip": null, "state": null, "first_name": "John", "last_name": "Dough" }, "phone": null, "email": "[email protected]" }, "shipping": { "address": { "city": "Karwar", "country": null, "line1": null, "line2": null, "line3": null, "zip": "581301", "state": "Karnataka", "first_name": "John", "last_name": "Dough" }, "phone": null, "email": "[email protected]" }, "customer_id": null, "customer_present": "Present", "description": null, "return_url": null, "setup_future_usage": "on_session", "apply_mit_exemption": "Skip", "statement_descriptor": null, "order_details": null, "allowed_payment_method_types": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "payment_link_enabled": "Skip", "payment_link_config": null, "request_incremental_authorization": "default", "expires_on": "2024-11-27T17:53:20.531Z", "frm_metadata": null, "request_external_three_ds_authentication": "Skip" }Ensure that the billing address and shipping address are returned as expected
confirm the payment with payment method billing address
{ "id": "12345_pay_01936ecc441b75819e855e842cc399fc", "status": "succeeded", "amount": { "order_amount": 100, "currency": "USD", "shipping_cost": null, "order_tax_amount": null, "external_tax_calculation": "skip", "surcharge_calculation": "skip", "surcharge_amount": null, "tax_on_surcharge": null, "net_amount": 100, "amount_to_capture": null, "amount_capturable": 0, "amount_captured": null }, "connector": "stripe", "client_secret": "12345_pay_01936ecc441b75819e855e842cc399fc_secret_01936ecc441c7c03a3cd39377ec07227", "created": "2024-11-27T18:05:00.828Z", "payment_method_data": { "billing": { "address": { "city": null, "country": null, "line1": null, "line2": null, "line3": null, "zip": null, "state": null, "first_name": "John", "last_name": null }, "phone": null, "email": null } }, "payment_method_type": "card", "payment_method_subtype": "credit", "next_action": null, "connector_transaction_id": "pi_3QPpbrD5R7gDAGff0I2xElva", "connector_reference_id": null, "merchant_connector_id": "mca_UNBvyDd9IHGPWPC3ORf5", "browser_info": null, "error": null }Ensure that the payment method billing address are returned as sent in the request
Retrieve the payment
{ "id": "12345_pay_01936ecc441b75819e855e842cc399fc", "status": "succeeded", "amount": { "order_amount": 100, "currency": "USD", "shipping_cost": null, "order_tax_amount": null, "external_tax_calculation": "skip", "surcharge_calculation": "skip", "surcharge_amount": null, "tax_on_surcharge": null, "net_amount": 100, "amount_to_capture": null, "amount_capturable": 0, "amount_captured": null }, "connector": "stripe", "client_secret": "12345_pay_01936ecc441b75819e855e842cc399fc_secret_01936ecc441c7c03a3cd39377ec07227", "created": "2024-11-27T18:05:00.828Z", "payment_method_data": { "billing": { "address": { "city": null, "country": null, "line1": null, "line2": null, "line3": null, "zip": null, "state": null, "first_name": "John", "last_name": null }, "phone": null, "email": null } }, "payment_method_type": "card", "payment_method_subtype": "credit", "connector_transaction_id": "pi_3QPpbrD5R7gDAGff0I2xElva", "connector_reference_id": null, "merchant_connector_id": "mca_UNBvyDd9IHGPWPC3ORf5", "browser_info": null, "error": null, "shipping": { "address": { "city": "Karwar", "country": null, "line1": null, "line2": null, "line3": null, "zip": "581301", "state": "Karnataka", "first_name": "John", "last_name": "Dough" }, "phone": null, "email": "[email protected]" }, "billing": { "address": { "city": null, "country": null, "line1": null, "line2": null, "line3": null, "zip": null, "state": null, "first_name": "John", "last_name": "Dough" }, "phone": null, "email": "[email protected]" } }Checklist
cargo +nightly fmt --allcargo clippy