Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Netcetera] add sca exemption #6611

Open
wants to merge 2 commits into
base: hs_sca_exemption
Choose a base branch
from
Open

feat(connector): [Netcetera] add sca exemption #6611

wants to merge 2 commits into from

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add sca exemption field to request for netcetera

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Nov 19, 2024
@Sakilmostak Sakilmostak added this to the November 2024 Release milestone Nov 19, 2024
@Sakilmostak Sakilmostak self-assigned this Nov 19, 2024
@Sakilmostak Sakilmostak requested a review from a team as a code owner November 19, 2024 11:58
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 19, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/netcetera/transformers.rs  26% smaller
  crates/router/src/connector/netcetera/netcetera_types.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
November 2024 Release
Development

Successfully merging this pull request may close these issues.
1 participant
@Sakilmostak