Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [JPMORGAN] add Payment flows for cards #6668

Merged
merged 12 commits into from
Dec 22, 2024
Merged

feat(connector): [JPMORGAN] add Payment flows for cards #6668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4d9e5d
feat(connector): [JPMORGAN] add Payment flows for cards
Nov 26, 2024
60317e3
fix: Handle default cases
Nov 28, 2024
1c4984e
fix: Handle default cases
Nov 29, 2024
ef344f9
fix: Handle default cases
Dec 5, 2024
5bde1cb
fix: Handle default cases
Dec 5, 2024
6edeb7d
fix: Handle default cases
Dec 6, 2024
0478f18
chore: Resolve PR Comments
Dec 9, 2024
1f05b80
chore: Resolve PR Comments
Dec 10, 2024
00115ff
chore: Resolve PR Comments
Dec 10, 2024
8415fe3
chore: Resolve PR Comments
Dec 17, 2024
1ea37c8
chore: Resolve PR Comments
Dec 18, 2024
2045fba
fix: Resolve PR Comments
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api-reference-v2/openapi_spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6250,6 +6250,7 @@
"helcim",
"iatapay",
"itaubank",
"jpmorgan",
"klarna",
"mifinity",
"mollie",
Expand Down Expand Up @@ -18682,6 +18683,7 @@
"helcim",
"iatapay",
"itaubank",
"jpmorgan",
"klarna",
"mifinity",
"mollie",
Expand Down
2 changes: 2 additions & 0 deletions api-reference/openapi_spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8754,6 +8754,7 @@
"helcim",
"iatapay",
"itaubank",
"jpmorgan",
"klarna",
"mifinity",
"mollie",
Expand Down Expand Up @@ -22889,6 +22890,7 @@
"helcim",
"iatapay",
"itaubank",
"jpmorgan",
"klarna",
"mifinity",
"mollie",
Expand Down
1 change: 1 addition & 0 deletions config/config.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url= "https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down
5 changes: 5 additions & 0 deletions config/deployments/integration_test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down Expand Up @@ -286,6 +287,10 @@ debit.currency = "USD"
ali_pay.currency = "GBP,CNY"
we_chat_pay.currency = "GBP,CNY"

[pm.filters.jpmorgan]
debit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }
credit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }

[pm_filters.klarna]
klarna = { country = "AU,AT,BE,CA,CZ,DK,FI,FR,DE,GR,IE,IT,NL,NZ,NO,PL,PT,ES,SE,CH,GB,US", currency = "CHF,DKK,EUR,GBP,NOK,PLN,SEK,USD,AUD,NZD,CAD" }

Expand Down
5 changes: 5 additions & 0 deletions config/deployments/production.toml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add pm filters in toml files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ iatapay.base_url = "https://iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://secure.api.itau/"
jpmorgan.base_url = "https://api-ms.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.klarna.com/"
mifinity.base_url = "https://secure.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down Expand Up @@ -320,6 +321,10 @@ debit.currency = "USD"
ali_pay.currency = "GBP,CNY"
we_chat_pay.currency = "GBP,CNY"

[pm.filters.jpmorgan]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify the currencies supported

debit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }
credit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }

[pm_filters.klarna]
klarna = { country = "AU,AT,BE,CA,CZ,DK,FI,FR,DE,GR,IE,IT,NL,NZ,NO,PL,PT,ES,SE,CH,GB,US", currency = "CHF,DKK,EUR,GBP,NOK,PLN,SEK,USD,AUD,NZD,CAD" }

Expand Down
5 changes: 5 additions & 0 deletions config/deployments/sandbox.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down Expand Up @@ -321,6 +322,10 @@ debit.currency = "USD"
ali_pay.currency = "GBP,CNY"
we_chat_pay.currency = "GBP,CNY"

[pm.filters.jpmorgan]
debit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }
credit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }

[pm_filters.klarna]
klarna = { country = "AU,AT,BE,CA,CZ,DK,FI,FR,DE,GR,IE,IT,NL,NZ,NO,PL,PT,ES,SE,CH,GB,US", currency = "CHF,DKK,EUR,GBP,NOK,PLN,SEK,USD,AUD,NZD,CAD" }

Expand Down
5 changes: 5 additions & 0 deletions config/development.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url= "https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down Expand Up @@ -489,6 +490,10 @@ paypal = { currency = "AUD,BRL,CAD,CNY,CZK,DKK,EUR,HKD,HUF,ILS,JPY,MYR,MXN,TWD,N
credit = { currency = "USD" }
debit = { currency = "USD" }

[pm.filters.jpmorgan]
debit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }
credit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" }

[pm_filters.klarna]
klarna = { country = "AU,AT,BE,CA,CZ,DK,FI,FR,DE,GR,IE,IT,NL,NZ,NO,PL,PT,ES,SE,CH,GB,US", currency = "AUD,EUR,EUR,CAD,CZK,DKK,EUR,EUR,EUR,EUR,EUR,EUR,EUR,NZD,NOK,PLN,EUR,EUR,SEK,CHF,GBP,USD" }

Expand Down
1 change: 1 addition & 0 deletions config/docker_compose.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
inespay.base_url = "https://apiflow.inespay.com/san/v21"
itaubank.base_url = "https://sandbox.devportal.itau.com.br/"
jpmorgan.base_url = "https://api-mock.payments.jpmorgan.com/api/v2"
jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com"
klarna.base_url = "https://api{{klarna_region}}.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com/"
mollie.base_url = "https://api.mollie.com/v2/"
Expand Down
5 changes: 3 additions & 2 deletions crates/api_models/src/connector_enums.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ pub enum Connector {
// Inespay,
Iatapay,
Itaubank,
//Jpmorgan,
Jpmorgan,
Klarna,
Mifinity,
Mollie,
Expand Down Expand Up @@ -173,6 +173,7 @@ impl Connector {
(Self::Airwallex, _)
| (Self::Deutschebank, _)
| (Self::Globalpay, _)
| (Self::Jpmorgan, _)
| (Self::Paypal, _)
| (Self::Payu, _)
| (Self::Trustpay, PaymentMethod::BankRedirect)
Expand Down Expand Up @@ -232,7 +233,7 @@ impl Connector {
| Self::Iatapay
// | Self::Inespay
| Self::Itaubank
//| Self::Jpmorgan
| Self::Jpmorgan
| Self::Klarna
| Self::Mifinity
| Self::Mollie
Expand Down
2 changes: 1 addition & 1 deletion crates/common_enums/src/connector_enums.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ pub enum RoutableConnectors {
Iatapay,
// Inespay,
Itaubank,
//Jpmorgan,
Jpmorgan,
Klarna,
Mifinity,
Mollie,
Expand Down
2 changes: 2 additions & 0 deletions crates/connector_configs/src/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ pub struct ConnectorConfig {
pub gpayments: Option<ConnectorTomlConfig>,
pub helcim: Option<ConnectorTomlConfig>,
// pub inespay: Option<ConnectorTomlConfig>,
pub jpmorgan: Option<ConnectorTomlConfig>,
pub klarna: Option<ConnectorTomlConfig>,
pub mifinity: Option<ConnectorTomlConfig>,
pub mollie: Option<ConnectorTomlConfig>,
Expand Down Expand Up @@ -359,6 +360,7 @@ impl ConnectorConfig {
Connector::Gpayments => Ok(connector_data.gpayments),
Connector::Helcim => Ok(connector_data.helcim),
// Connector::Inespay => Ok(connector_data.inespay),
Connector::Jpmorgan => Ok(connector_data.jpmorgan),
Connector::Klarna => Ok(connector_data.klarna),
Connector::Mifinity => Ok(connector_data.mifinity),
Connector::Mollie => Ok(connector_data.mollie),
Expand Down
41 changes: 41 additions & 0 deletions crates/connector_configs/toml/development.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,6 +1731,47 @@ api_key="Client Secret"
api_secret="Certificates"
key2="Certificate Key"

[jpmorgan]
[[jpmorgan.credit]]
payment_method_type = "American Express"
[[jpmorgan.credit]]
payment_method_type = "ChaseNet"
[[jpmorgan.credit]]
payment_method_type = "Diners Club"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "JCB"
[[jpmorgan.credit]]
payment_method_type = "Mastercard"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "UnionPay"
[[jpmorgan.credit]]
payment_method_type = "Visa"
[[jpmorgan.debit]]
payment_method_type = "American Express"
[[jpmorgan.debit]]
payment_method_type = "ChaseNet"
[[jpmorgan.debit]]
payment_method_type = "Diners Club"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "JCB"
[[jpmorgan.debit]]
payment_method_type = "Mastercard"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "UnionPay"
[[jpmorgan.debit]]
payment_method_type = "Visa"
[jpmorgan.connector_auth.BodyKey]
api_key="Client ID"
key1="Client Secret"

[klarna]
[[klarna.pay_later]]
payment_method_type = "klarna"
Expand Down
40 changes: 40 additions & 0 deletions crates/connector_configs/toml/production.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,6 +1443,46 @@ api_key="Client Secret"
api_secret="Certificates"
key2="Certificate Key"

[jpmorgan]
[[jpmorgan.credit]]
payment_method_type = "American Express"
[[jpmorgan.credit]]
payment_method_type = "ChaseNet"
[[jpmorgan.credit]]
payment_method_type = "Diners Club"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "JCB"
[[jpmorgan.credit]]
payment_method_type = "Mastercard"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "UnionPay"
[[jpmorgan.credit]]
payment_method_type = "Visa"
[[jpmorgan.debit]]
payment_method_type = "American Express"
[[jpmorgan.debit]]
payment_method_type = "ChaseNet"
[[jpmorgan.debit]]
payment_method_type = "Diners Club"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "JCB"
[[jpmorgan.debit]]
payment_method_type = "Mastercard"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "UnionPay"
[[jpmorgan.debit]]
payment_method_type = "Visa"
[jpmorgan.connector_auth.BodyKey]
api_key="Access Token"

[klarna]
[[klarna.pay_later]]
payment_method_type = "klarna"
Expand Down
40 changes: 40 additions & 0 deletions crates/connector_configs/toml/sandbox.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,46 @@ api_key="Client Secret"
api_secret="Certificates"
key2="Certificate Key"

[jpmorgan]
[[jpmorgan.credit]]
payment_method_type = "American Express"
[[jpmorgan.credit]]
payment_method_type = "ChaseNet"
[[jpmorgan.credit]]
payment_method_type = "Diners Club"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "JCB"
[[jpmorgan.credit]]
payment_method_type = "Mastercard"
[[jpmorgan.credit]]
payment_method_type = "Discover"
[[jpmorgan.credit]]
payment_method_type = "UnionPay"
[[jpmorgan.credit]]
payment_method_type = "Visa"
[[jpmorgan.debit]]
payment_method_type = "American Express"
[[jpmorgan.debit]]
payment_method_type = "ChaseNet"
[[jpmorgan.debit]]
payment_method_type = "Diners Club"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "JCB"
[[jpmorgan.debit]]
payment_method_type = "Mastercard"
[[jpmorgan.debit]]
payment_method_type = "Discover"
[[jpmorgan.debit]]
payment_method_type = "UnionPay"
[[jpmorgan.debit]]
payment_method_type = "Visa"
[jpmorgan.connector_auth.BodyKey]
api_key="Access Token"

[klarna]
[[klarna.pay_later]]
payment_method_type = "klarna"
Expand Down
Loading
Loading