-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [JPMORGAN] add Payment flows for cards #6668
Changes from 10 commits
f4d9e5d
60317e3
1c4984e
ef344f9
5bde1cb
6edeb7d
0478f18
1f05b80
00115ff
8415fe3
1ea37c8
2045fba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add pm filters in toml files. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. alright |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,7 @@ iatapay.base_url = "https://iata-pay.iata.org/api/v1" | |
inespay.base_url = "https://apiflow.inespay.com/san/v21" | ||
itaubank.base_url = "https://secure.api.itau/" | ||
jpmorgan.base_url = "https://api-ms.payments.jpmorgan.com/api/v2" | ||
jpmorgan.secondary_base_url="https://id.payments.jpmorgan.com/am/oauth2/alpha/access_token" | ||
klarna.base_url = "https://api{{klarna_region}}.klarna.com/" | ||
mifinity.base_url = "https://secure.mifinity.com/" | ||
mollie.base_url = "https://api.mollie.com/v2/" | ||
|
@@ -320,6 +321,10 @@ debit.currency = "USD" | |
ali_pay.currency = "GBP,CNY" | ||
we_chat_pay.currency = "GBP,CNY" | ||
|
||
[pm.filters.jpmorgan] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please verify the currencies supported |
||
debit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" } | ||
credit = { country = "CA, EU, UK, US", currency = "CAD, EUR, GBP, USD" } | ||
|
||
[pm_filters.klarna] | ||
klarna = { country = "AU,AT,BE,CA,CZ,DK,FI,FR,DE,GR,IE,IT,NL,NZ,NO,PL,PT,ES,SE,CH,GB,US", currency = "CHF,DKK,EUR,GBP,NOK,PLN,SEK,USD,AUD,NZD,CAD" } | ||
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does jpmorgan use same base url in both sbx and prod env? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, it uses different |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check if jpmorgan is needs to be added in temp_locker_enable_config There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't need to add that here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we including the entire URL here instead of just the base URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the secondary base url is different from the base url, it is actually used for retrieving the access token, it is a separate api call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be including only the base URL here instead of the entire URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so where should we include the access token flow's url?