ci(cypress): Add Session Token Testcases #6683
Open
+213
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Gnanasundari24
added
A-CI-CD
Gnanasundari24
changed the title
jagan-jaya
approved these changes
Nov 29, 2024
Comment on lines
+134
to
+140
| merchant_identifier: | ||
| "6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", | ||
| psp_id: | ||
| "6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", | ||
| operational_analytics_identifier: | ||
| "Apple pay:6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", | ||
| domain_name: "hyperswitch-demo-store.netlify.app", |
There was a problem hiding this comment.
are those dummy values?
There was a problem hiding this comment.
Merchant identifier which is in the encrypted format
There was a problem hiding this comment.
move this to creds.json file it should not be hardcoded here
jagan-jaya
requested changes
Nov 29, 2024
Comment on lines
+135
to
+139
| "6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", | ||
| psp_id: | ||
| "6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", | ||
| operational_analytics_identifier: | ||
| "Apple pay:6ACD34193A900BA07E215155E3647CF4759340CF486BABAEE6C0840F9267AB10", |
There was a problem hiding this comment.
remove/replace with dummy values if not already
There was a problem hiding this comment.
move this to creds.json file it should not be hardcoded here
pixincreate
added
the
S-needs-conflict-resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added Session Token Call Testcases in cypress
Additional Changes
Motivation and Context
To include session token testcases in automation.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy