-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): populate card network in the network transaction id based MIT flow #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
A-core
Area: Core flows
C-bug
Category: Bug
A-payment-methods
Area: Payment Methods
labels
Nov 28, 2024
Changed Files
|
ShankarSinghC
changed the title
fix(router):
fix(router): populate card network in the network transaction id based MIT flow
Nov 28, 2024
jagan-jaya
approved these changes
Nov 28, 2024
deepanshu-iiitu
approved these changes
Nov 28, 2024
hrithikesh026
approved these changes
Nov 28, 2024
@ShankarSinghC As its a bug fix i'm merging it now and can you please add the cypress testcases for this and raise it as a seperate PR |
pixincreate
added a commit
that referenced
this pull request
Dec 2, 2024
…ed-cypress * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.12.02.0 refactor(users): Use domain email type in user DB functions (#6699) fix(openapi): Standardise API naming scheme for V2 (#6510) feat(users): add tenant id reads in user roles (#6661) fix(users): Mark user as verified if user logins from SSO (#6694) feat(payments): [Payment links] add showCardFormByDefault config for payment links (#6663) feat(connector): [REDSYS] add Connector Template Code (#6659) refactor(currency_conversion): release redis lock if api call fails (#6671) feat(connector): [Adyen] Fetch email from customer email for payment request (#6676) fix(router): populate card network in the network transaction id based MIT flow (#6690) refactor(router): [ZSL] remove partially capture status (#6689) fix(opensearch): handle empty free-text query search in global search (#6685) fix(analytics): fix first_attempt filter value parsing for Payments (#6667) chore(version): 2024.11.29.0
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In the PG agnostic MIT flow (card details with network transaction id) the card network is being passed a null in the response. As the card network fetched form the card info lookup is not being used.
Additionally this pr also contains the changes to include the
network_transaction_id_supported_connectors
inproduction.toml
. And pass internet as the commerce_indicator for discover cards in cybersource.Additional Changes
Motivation and Context
How did you test it?
-> Create merchant account and merchant connector account
-> enable
is_connector_agnostic_mit_enabled
flag-> Create a payment with
"setup_future_usage": "off_session",
-> Create a payment for the same customer
-> List customer pml with the client_secret
-> Confirm the payment
-> Create a cit with stripe and perform the recurring with cybersource
-> Create payment for same customer
-> Customer pml
-> Confirm with cybersource
-> Psync
Checklist
cargo +nightly fmt --all
cargo clippy